fix(database): GetTraderConfig missing critical fields causes edit to fail

[the-dev-z]

🐛 Problem

When editing a trader, the configuration cannot be displayed correctly:

• BTC/ETH leverage shows 0 (should show user-configured value like 5 or 10)
• Altcoin leverage shows 0 (should show user-configured value)
• Trading symbols is empty (should show "BTCUSDT,ETHUSDT,..." user-selected pairs)
• All custom configurations are lost

Impact: Users cannot edit trader configurations properly and must re-enter all settings

🔍 Root Cause

The GetTraderConfig function in config/database.go:878 has incomplete SQL query:

• SELECT statement missing 9 critical fields
• Scan variables missing corresponding bindings
• These fields always return zero/empty values

✅ Fix

1. Add missing SELECT fields (config/database.go:881-889)

COALESCE(t.btc_eth_leverage, 5) as btc_eth_leverage,
COALESCE(t.altcoin_leverage, 5) as altcoin_leverage,
COALESCE(t.trading_symbols, '') as trading_symbols,
COALESCE(t.use_coin_pool, 0) as use_coin_pool,
COALESCE(t.use_oi_top, 0) as use_oi_top,
COALESCE(t.custom_prompt, '') as custom_prompt,
COALESCE(t.override_base_prompt, 0) as override_base_prompt,
COALESCE(t.system_prompt_template, 'default') as system_prompt_template,
COALESCE(t.is_cross_margin, 1) as is_cross_margin,

2. Add corresponding Scan variables (config/database.go:908-911)

&trader.BTCETHLeverage, &trader.AltcoinLeverage, &trader.TradingSymbols,
&trader.UseCoinPool, &trader.UseOITop,
&trader.CustomPrompt, &trader.OverrideBasePrompt, &trader.SystemPromptTemplate,
&trader.IsCrossMargin,

3. Verify field count matches

• SELECT fields: 43 ✅
• Scan variables: 43 ✅

🧪 Testing

Compilation

✅ go build -o nofx
# No errors

Field count verification

Total SELECT fields: 43
- Trader basic: 8 fields
- Trader config: 9 fields (leverage, symbols, prompts, etc.)
- Timestamps: 2 fields
- AI Model: 10 fields
- Exchange: 14 fields

Total Scan variables: 43 ✅ Matches!

Manual test

1. Create trader with leverage=10,5 and symbols="BTCUSDT,ETHUSDT,SOLUSDT"
2. Edit trader
3. ✅ All values display correctly (no more zeros)

📊 Impact

Before Fix

{
  "btc_eth_leverage": 0,
  "altcoin_leverage": 0,
  "trading_symbols": ""
}

After Fix

{
  "btc_eth_leverage": 10,
  "altcoin_leverage": 5,
  "trading_symbols": "BTCUSDT,ETHUSDT,SOL"
}

---

Type: Bug Fix
Priority: 🔥 HIGH - Core functionality broken

[github-actions]

🤖 Advisory Check Results

These are advisory checks to help improve code quality. They won't block your PR from being merged.

Note: PR title and size checks are handled by the main workflow and may appear in a separate comment.

🔧 Backend Checks

Go Formatting: ⚠️ Needs formatting

Files needing formatting

api/server.go
auth/auth.go
manager/trader_manager.go
trader/aster_trader.go
trader/auto_trader.go
trader/binance_futures.go
trader/hyperliquid_trader.go

Go Vet: ✅ Good
Tests: ✅ Passed

Fix locally:

go fmt ./...      # Format code
go vet ./...      # Check for issues
go test ./...     # Run tests

⚛️ Frontend Checks

Build & Type Check: ✅ Success

Fix locally:

cd web
npm run build  # Test build (includes type checking)

---

📖 Resources

• Contributing Guidelines
• Migration Guide

Questions? Feel free to ask in the comments! 🙏

---

These checks are advisory and won't block your PR from being merged. This comment is automatically generated from pr-checks-run.yml.