Merged
Conversation
|
Changes made by this pull request: nixtla/nixtla_client.py nixtla_tests/conftest.py nixtla_tests/nixtla_client/test_nixtla_client.py |
Contributor
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:
Experiment 2: air-passengersDescription:
Results:
Plot:
Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:
Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot:
|
elephaint
commented
Nov 29, 2025
| model_input_size, | ||
| ) | ||
| in_sample_payload = _forecast_payload_to_in_sample(payload, insample_h, n_windows) | ||
| logger.info("Calling Historical Forecast Endpoint...") |
Contributor
Author
There was a problem hiding this comment.
Fwiw keeping the same logging message here to not confuse users
elephaint
commented
Nov 29, 2025
| ("cross_validation", {"h": 7, "n_windows": 2}, False), | ||
| ("forecast", {"h": 7, "add_history": True}, False), | ||
| ("cross_validation", {"h": 7, "n_windows": 2}, True), | ||
| ("forecast", {"h": 7, "add_history": True}, True), |
Contributor
Author
There was a problem hiding this comment.
I think these two tests should be "True", otherwise they are identical to the ones above it.
elephaint
force-pushed
the
fix/deprecate_insample_endpoint
branch
from
0964a72 to
c7b3af7
Compare
goodwanghan
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
Tests fail until ltm-api that supports feature_contributions for cross-validation has been released.