Skip to content

nodejs-12_x: 12.4.0 -> 12.5.0 #63883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marsam merged 1 commit into from
Jun 29, 2019
Merged

nodejs-12_x: 12.4.0 -> 12.5.0 #63883

marsam merged 1 commit into from
Jun 29, 2019
+2 −4

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Jun 28, 2019

Motivation for this change

Changelog: https://github.com/nodejs/node/releases/tag/v12.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 28, 2019
ivan
ivan approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally on x86_64 NixOS and my nodejs applications work fine on 12.5.0.

@marsam marsam merged commit 4a679d4 into NixOS:master Jun 29, 2019
@marsam marsam deleted the update-nodejs-12_x branch June 29, 2019 01:58
@ivan
Copy link
Member

ivan commented Jun 29, 2019

I just noticed this regression in 12.5.0, but not sure if anyone else is affected: nodejs/node#24260 (comment)

@marsam
Copy link
Contributor Author

marsam commented Jul 3, 2019

fyi, it was fixed in upstream which is included in the v12.6.0 release

@ivan
Copy link
Member

ivan commented Jul 4, 2019 •
edited
Loading

node 12.6.0 is still broken w.r.t. my bug (SIGTTOU hang on exit when there is a PTY) that I haven't properly reported, they fixed something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ivan ivan ivan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marsam @ivan