gemini-cli: build bundle, 0.30.0 -> 0.31.0 by matshch · Pull Request #493475 · NixOS/nixpkgs

matshch · 2026-02-23T22:46:52Z

This decreases output path size 15 times and makes package layout a lot closer to gemini-cli-bin.

Also includes update to 0.31.0, as it requires some changes in the build process as well:

Things done

matshch · 2026-02-23T22:49:05Z

@pedrobrantes @xiaoxiangmoe @FlameFlag @taranarmo what do you think about this change? Is there any reason to bring the whole node_modules tree when there exists a convenient way to package everything into one file?

taranarmo · 2026-02-24T12:04:03Z

I am okay with the change as soon as the package works, though my knowledge in Node and JS is not sufficient to answer the rest 😅

xiaoxiangmoe · 2026-02-24T16:39:14Z

If you use cp -r bundle $out/share/gemini-cli, does it correctly handle the native dependency requirements in node_modules? Such as node-pty, keytar and so on.

xiaoxiangmoe · 2026-02-24T16:47:36Z

I had considered switching to a build bundle, but ultimately decided to keep the current implementation that includes node_modules for the following reasons:

Switching to build bundles would require special handling of npm dependencies related to node addons. It looks a little troublesome. I haven't debugged it in detail yet.
There needs to be an implementation that aligns with the implementation of npm install @google/gemini-cli. Fortunately, this version without bundles seems to behave consistently with npm install @google/gemini-cli and npx @google/gemini-cli.

ljxfstorm · 2026-02-25T14:41:47Z

Should we consider introducing this as a variant rather than a full replacement?

Additionally, we could then deprecate gemini-cli-bin to streamline maintenance going forward.

Historically, we introduced the -bin package because upstream builds were unstable and it offered a much smaller size. Now that upstream has stabilized and the bundle variant addresses the output size issue, maintaining both packages feels redundant.

The only trade-off is the build-time overhead: unless the bundle variant is cached, users will need to perform a full source build, which is much heavier than simply fetching the pre-built -bin.
Do we have a way to confirm whether the bundle build will be included in the Hydra cache?

matshch · 2026-02-25T14:45:27Z

I have checked and indeed there are some differences in behavior:

The most noticeable one is that the gemini-cli from master supports interactive shell commands (due to node-pty presence), and both gemini-cli-bin and gemini-cli from this PR do not.
It looks like gemini-cli from master should also utilize system keychain for API key storage, but it does not work for me for some reason.

I'm just disappointed that we have to bring such a big closure when we only need like 5% of that.

matshch · 2026-02-25T23:08:06Z

I think I've cracked it:

They define these native packages as external: https://github.com/google-gemini/gemini-cli/blob/v0.29.5/esbuild.config.js#L57-L67
They are the same packages they define as optional dependencies: https://github.com/google-gemini/gemini-cli/blob/v0.29.5/package.json#L135-L145
If we leave just these packages in node_modules, they are successfully imported from the bundle as they are defined as external.

I've also fixed keytar cleanup so that saving API key to the system keychain actually works now!

matshch · 2026-02-25T23:14:42Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 493475
Commit: 15f1b7e619537a8fd452e2fa2cef12cddea502d0

`x86_64-linux`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`aarch64-linux`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`x86_64-darwin`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`aarch64-darwin`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

FlameFlag

Awesome work, LGTM!

FlameFlag · 2026-02-26T00:20:23Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 493475
Commit: 15f1b7e619537a8fd452e2fa2cef12cddea502d0 (subsequent changes)
Merge: a89a1f0c9af4fd0b57abb96e13746713fac54dc2

Logs: https://github.com/FlameFlag/nixpkgs-review-gha/actions/runs/22421838617

`x86_64-linux`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`aarch64-linux`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`x86_64-darwin` (sandbox = relaxed)

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`aarch64-darwin` (sandbox = relaxed)

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

pkgs/by-name/ge/gemini-cli/package.nix

ljxfstorm · 2026-03-02T08:26:55Z

Upstream PR google-gemini/gemini-cli#20154 modified the shebang in gemini.js (v0.31.0), which patchShebangs cannot handle correctly.
I've introduced makeWrapper in #495738 to resolve this for gemini-cli-bin.
I'm concerned this might also impact the bundle build.

This decreases output path size 15 times and makes package layout a lot closer to gemini-cli-bin, while saving all the features of the native installation.

matshch · 2026-03-03T18:13:54Z

@ljxfstorm, thanks for the notice, I've pushed an update that incorporates your solution from #495738.

matshch · 2026-03-03T18:20:40Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 493475
Commit: d5725f96cf8f30d7589a9264ffd56eea820514ff

`x86_64-linux`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`aarch64-linux`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`x86_64-darwin`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

`aarch64-darwin`

✅ 2 packages built:

gemini-cli
vscode-extensions.Google.gemini-cli-vscode-ide-companion

pkgs/by-name/ge/gemini-cli/package.nix

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Feb 23, 2026

matshch force-pushed the gemini-cli-package branch from 96e907a to 15f1b7e Compare February 25, 2026 23:00

matshch marked this pull request as ready for review February 25, 2026 23:08

nixpkgs-ci bot requested review from FlameFlag, pedrobrantes, taranarmo and xiaoxiangmoe February 25, 2026 23:17

FlameFlag approved these changes Feb 26, 2026

View reviewed changes

nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 26, 2026

xiaoxiangmoe reviewed Feb 26, 2026

View reviewed changes

pkgs/by-name/ge/gemini-cli/package.nix Show resolved Hide resolved

matshch mentioned this pull request Feb 26, 2026

Bundle build is missing native extensions google-gemini/gemini-cli#20445

Open

jtliang24 mentioned this pull request Feb 28, 2026

gemini-cli: 0.30.0 -> 0.31.0 #495269

Closed

13 tasks

nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 2, 2026

matshch added 2 commits March 3, 2026 11:32

gemini-cli: build bundle

9b58c9c

This decreases output path size 15 times and makes package layout a lot closer to gemini-cli-bin, while saving all the features of the native installation.

gemini-cli: 0.30.0 -> 0.31.0

d5725f9

matshch force-pushed the gemini-cli-package branch from 15f1b7e to d5725f9 Compare March 3, 2026 18:13

nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 3, 2026

nixpkgs-ci bot added the 8.has: package (update) This PR updates a package to a newer version label Mar 3, 2026

matshch changed the title ~~gemini-cli: build bundle~~ gemini-cli: build bundle, 0.30.0 -> 0.31.0 Mar 3, 2026

ljxfstorm mentioned this pull request Mar 9, 2026

gemini-cli-bin: include node-pty #494135

Open

3 tasks

myaaaaaaaaa reviewed Mar 9, 2026

View reviewed changes

pkgs/by-name/ge/gemini-cli/package.nix Show resolved Hide resolved

Aleksanaa added this pull request to the merge queue Mar 10, 2026

Merged via the queue into NixOS:master with commit 54a9d10 Mar 10, 2026
32 of 34 checks passed

matshch deleted the gemini-cli-package branch March 10, 2026 21:21

Uh oh!

Conversation

matshch commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

matshch commented Feb 23, 2026

Uh oh!

taranarmo commented Feb 24, 2026

Uh oh!

xiaoxiangmoe commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaoxiangmoe commented Feb 24, 2026

Uh oh!

ljxfstorm commented Feb 25, 2026

Uh oh!

matshch commented Feb 25, 2026

Uh oh!

matshch commented Feb 25, 2026

Uh oh!

matshch commented Feb 25, 2026

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

FlameFlag left a comment

Choose a reason for hiding this comment

Uh oh!

FlameFlag commented Feb 26, 2026

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = relaxed)

aarch64-darwin (sandbox = relaxed)

Uh oh!

Uh oh!

ljxfstorm commented Mar 2, 2026

Uh oh!

matshch commented Mar 3, 2026

Uh oh!

matshch commented Mar 3, 2026

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

matshch commented Feb 23, 2026 •

edited

Loading

xiaoxiangmoe commented Feb 24, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = relaxed)

`aarch64-darwin` (sandbox = relaxed)

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`