Skip to content

navidrome: breakfix for cgo flag issue in 25.11-release#493362

Closed
tebriel wants to merge 1 commit intoNixOS:release-25.11from
tebriel:navidrome/build-fix
Closed

navidrome: breakfix for cgo flag issue in 25.11-release#493362
tebriel wants to merge 1 commit intoNixOS:release-25.11from
tebriel:navidrome/build-fix

Conversation

@tebriel
Copy link
Contributor

@tebriel tebriel commented Feb 23, 2026

Fixes #481611

This issue is what we're running into on release-25.11: golang/go#77387
Homebrew patched go: Homebrew/homebrew-core#265724
Just updated to allow-list the flag causing the issue.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@tebriel tebriel mentioned this pull request Feb 23, 2026
13 tasks
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Important

f899a3a is not a cherry-pick, because: Only broken in release-25.11. Please review this commit manually.

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

@nixpkgs-ci nixpkgs-ci bot requested review from aciceri and squalus February 23, 2026 15:26
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 4.workflow: backport This targets a stable branch labels Feb 23, 2026
@not-my-profile
Copy link
Contributor

not-my-profile commented Feb 23, 2026

Thanks, I can confirm that this builds :)

@tebriel tebriel force-pushed the navidrome/build-fix branch from b5d9a92 to 2d0c953 Compare February 23, 2026 19:18
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 23, 2026
Not-cherry-picked-because: Only broken in release-25.11
@tebriel tebriel force-pushed the navidrome/build-fix branch from 2d0c953 to f899a3a Compare February 23, 2026 19:42
@andresilva
Copy link
Member

Seems like this is also needed on unstable now.

@andresilva
Copy link
Member

#494296

@tebriel
Copy link
Contributor Author

tebriel commented Feb 26, 2026

Closing in favor of #494296

@tebriel tebriel closed this Feb 26, 2026
@tebriel tebriel deleted the navidrome/build-fix branch February 26, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants