-
-
Notifications
You must be signed in to change notification settings - Fork 17.2k
wash-cli: 0.39.0 -> 1.0.0-beta.10 #457188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Linux build failing because of some tests, checking which need to be skipped here in addition Edit: fixed, only one other test that tried to download things from the internet |
a0365c8 to
9c9af80
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nix-shell:~/.cache/nixpkgs-review/pr-457188]$ ./results/wash-cli-aarch64-darwin/bin/wash --version
wash 1.0.0-beta.10you could add a versionCheckHook here, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 457188
Commit: 9c9af80c0ea8e66687645abf16fc47ad25e9f09f
x86_64-linux
✅ 1 package built:
- wash-cli
https://github.com/wasmCloud/wash/releases/tag/wash-v1.0.0-beta.10
wash-cli was renamed to just wash upstream (although the binary name already was
washbefore), but I kept the package name unchanged for now.I'm not sure to what degree the previous version of wash-cli is affected by CVE-2025-62518 (tracking issue #455265), but it contained the vulnerable tokio-tar dependency in its lockfile while the new version does not. Seeing that wash appears to act as a package manager to some degree, I'm going with "better be safe than sorry" and add the security label to this PR.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.