Skip to content

Conversation

@niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Oct 31, 2025

https://github.com/wasmCloud/wash/releases/tag/wash-v1.0.0-beta.10

wash-cli was renamed to just wash upstream (although the binary name already was wash before), but I kept the package name unchanged for now.

I'm not sure to what degree the previous version of wash-cli is affected by CVE-2025-62518 (tracking issue #455265), but it contained the vulnerable tokio-tar dependency in its lockfile while the new version does not. Seeing that wash appears to act as a package manager to some degree, I'm going with "better be safe than sorry" and add the security label to this PR.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@niklaskorz niklaskorz added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 31, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 31, 2025
@nix-owners nix-owners bot requested a review from bloveless October 31, 2025 09:04
@niklaskorz
Copy link
Contributor Author

niklaskorz commented Oct 31, 2025

Linux build failing because of some tests, checking which need to be skipped here in addition

Edit: fixed, only one other test that tried to download things from the internet

@bengsparks
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457188
Commit: 9c9af80c0ea8e66687645abf16fc47ad25e9f09f


aarch64-linux

✅ 1 package built:
  • wash-cli

aarch64-darwin

✅ 1 package built:
  • wash-cli

Copy link
Contributor

@bengsparks bengsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nix-shell:~/.cache/nixpkgs-review/pr-457188]$ ./results/wash-cli-aarch64-darwin/bin/wash --version
wash 1.0.0-beta.10

you could add a versionCheckHook here, otherwise LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 1, 2025
Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457188
Commit: 9c9af80c0ea8e66687645abf16fc47ad25e9f09f


x86_64-linux

✅ 1 package built:
  • wash-cli

@LeSuisse LeSuisse added this pull request to the merge queue Nov 1, 2025
Merged via the queue into NixOS:master with commit 02f9db5 Nov 1, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants