Skip to content

Conversation

@YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Aug 29, 2025

Backport to release-25.05, done manually because of failed automatic backport by a label in #409797.

  • Before merging, ensure that this backport is acceptable for the release.

    • Even as a non-committer, if you find that it is not acceptable, leave a comment.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Warning

Difference between ea4ddd9 and original dd12290 may warrant inspection.

Show diff
@@ Commit message
 
     This reverts commit de74f9caf0854a9ee8c39774cf4521870fa1f44a.
 
+    (cherry picked from commit dd12290517ff6e57ab2ca384b101e0cdc617570c)
+
  ## doc/redirects.json ##
 @@
    "sec-language-cosmic": [
@@ doc/redirects.json
      "index.html#sec-modify-via-packageOverrides"
    ],
 @@
-   "var-go-buildTestBinaries": [
-     "index.html#var-go-buildTestBinaries"
+   "typst-package-scope-and-usage": [
+     "index.html#typst-package-scope-and-usage"
    ],
 +  "var-meta-identifiers-cpe": [
 +    "index.html#var-meta-identifiers-cpe"
@@ pkgs/by-name/he/hello/package.nix: stdenv.mkDerivation (finalAttrs: {
 
  ## pkgs/development/compilers/gcc/common/meta.nix ##
 @@ pkgs/development/compilers/gcc/common/meta.nix: in
+   platforms = platforms.unix;
    teams = [ teams.gcc ];
-   mainProgram = "${targetPrefix}gcc";
  
 +  identifiers.cpeParts.vendor = "gnu";
  }
 
  ## pkgs/development/compilers/gcc/default.nix ##
 @@ pkgs/development/compilers/gcc/default.nix: pipe
+           longDescription
            platforms
            teams
-           mainProgram
 +          identifiers
            ;
-       };
        }
+       // optionalAttrs (!atLeast11) {
 
  ## pkgs/development/compilers/llvm/common/common-let.nix ##
 @@ pkgs/development/compilers/llvm/common/common-let.nix: rec {
-       ++ lib.platforms.riscv
-       ++ lib.platforms.m68k
-       ++ lib.platforms.loongarch64;
+       ++ lib.optionals (lib.versionAtLeast release_version "7") lib.platforms.riscv
+       ++ lib.optionals (lib.versionAtLeast release_version "14") lib.platforms.m68k
+       ++ lib.optionals (lib.versionAtLeast release_version "16") lib.platforms.loongarch64;
 +
 +    identifiers.cpeParts.vendor = "llvm";
    };
@@ pkgs/stdenv/generic/check-meta.nix: let
    # but it's not part of the actual derivation, i.e., it's not
    # passed to the builder and is not a dependency.  But since we
 @@ pkgs/stdenv/generic/check-meta.nix: let
+       # if you add a new maintainer or team attribute please ensure that this expectation is still met.
        maintainers =
          attrs.meta.maintainers or [ ] ++ concatMap (team: team.members or [ ]) attrs.meta.teams or [ ];
- 
+-    }
+-    // {
++
 +      identifiers =
 +        let
 +          defaultCPEParts = {

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: kernel The Linux kernel 6.topic: stdenv Standard environment 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 4.workflow: backport This targets a stable branch labels Aug 29, 2025
@nixpkgs-ci nixpkgs-ci bot added the 8.has: documentation This PR adds or changes documentation label Aug 29, 2025
@infinisil
Copy link
Member

@YorikSar Based on the shown diff it doesn't look right 🤔

@YorikSar
Copy link
Contributor Author

@infinisil diff between patches shows two places where conflicts happened: two in GCC package and one in meta itself. Conflicts in GCC boil down to the addition of mainProgram, and in meta - to lack of optimisation that landed separately in master and was not backported (I’ve replaced // with the new code here). If you inspect the new patch visually, it doesn’t have any additional pieces.

@vcunat vcunat marked this pull request as draft August 30, 2025 06:27
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#409797 (comment) needs addressing first.

@github-project-automation github-project-automation bot moved this to In Progress in Stdenv Aug 30, 2025
This reverts commit de74f9c.

(cherry picked from commit dd12290)
nix-env writes a warning for each derivation that has null in its meta
values, so fields without known values are removed from the result.

Fixes issue raised by @K900 in NixOS#409797 (comment)

(cherry picked from commit a178fd8)
(cherry picked from commit 5e1eee5)
@YorikSar YorikSar force-pushed the backport-cpe-to-release-25.05 branch from 460d0a5 to 4895d62 Compare September 15, 2025 16:22
@YorikSar YorikSar marked this pull request as ready for review September 15, 2025 16:23
@YorikSar YorikSar closed this Nov 3, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Stdenv Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants