Skip to content

python3Packages.skops: Ignore new DeprecationWarning that breaks testing#426189

Merged
drupol merged 1 commit intoNixOS:masterfrom
sarahec:skops-testfix
Jul 20, 2025
Merged

python3Packages.skops: Ignore new DeprecationWarning that breaks testing#426189
drupol merged 1 commit intoNixOS:masterfrom
sarahec:skops-testfix

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented Jul 17, 2025

skops/io/tests/test_persist.py::test_dump_and_load_with_file_wrapper throws a DeprecationWarning from scipy.optimize

Ignored the warning and filed skops-dev/skops#479
(Also removed a now-obsolete pythonOlder)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jul 17, 2025
@nix-owners nix-owners bot requested a review from bcdarwin July 17, 2025 19:39
@sarahec
Copy link
Contributor Author

sarahec commented Jul 17, 2025

Found in nixpkgs-review of #409698

@sarahec sarahec mentioned this pull request Jul 17, 2025
13 tasks
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Nixpkgs is moving from pytestFlagsArray to pytestFlags for some technical reason related to structured attributes; see #424782.

@sarahec
Copy link
Contributor Author

sarahec commented Jul 18, 2025

Note: Nixpkgs is moving from pytestFlagsArray to pytestFlags for some technical reason related to structured attributes; see #424782.

Thank you, changed.

@bcdarwin
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426189
Commit: ab1d06929d12d9a5df2283fbbbbe24689f246657


x86_64-linux

✅ 8 packages built:
  • python312Packages.skops
  • python312Packages.skops.dist
  • python312Packages.txtai
  • python312Packages.txtai.dist
  • python313Packages.skops
  • python313Packages.skops.dist
  • python313Packages.txtai
  • python313Packages.txtai.dist

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 18, 2025
@sarahec sarahec requested a review from drupol July 20, 2025 02:29
@drupol drupol merged commit 890b559 into NixOS:master Jul 20, 2025
27 of 29 checks passed
@sarahec sarahec deleted the skops-testfix branch July 20, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants