playwright-driver: fix webkit build#425767
Closed
kalekseev wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
3 tasks
tobiasBora
approved these changes
Jul 16, 2025
Contributor
tobiasBora
left a comment
There was a problem hiding this comment.
I can confirm this works nicely. Good for me (though on the long term wouldn't it be better to copy/paste the whole derivation since anyway we pin an older version here? this way we are resilient to changes in the original derivation).
13 tasks
13 tasks
Contributor
|
heya! the build is nearly working for me, but |
Contributor
Author
I believe this problem was fixed in master #418639 |
13 tasks
13 tasks
lo1tuma
approved these changes
Jul 21, 2025
screendriver
approved these changes
Jul 21, 2025
13 tasks
Contributor
Author
|
the patch included into #427631 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #425505
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.