Skip to content

playwright-driver: fix webkit build#425767

Closed
kalekseev wants to merge 1 commit intoNixOS:masterfrom
kalekseev:fix-pw-webkit
Closed

playwright-driver: fix webkit build#425767
kalekseev wants to merge 1 commit intoNixOS:masterfrom
kalekseev:fix-pw-webkit

Conversation

@kalekseev
Copy link
Contributor

fixes #425505

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 16, 2025
@tobiasBora tobiasBora self-requested a review July 16, 2025 13:40
Copy link
Contributor

@tobiasBora tobiasBora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works nicely. Good for me (though on the long term wouldn't it be better to copy/paste the whole derivation since anyway we pin an older version here? this way we are resilient to changes in the original derivation).

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 16, 2025
@sarahec sarahec mentioned this pull request Jul 17, 2025
13 tasks
@muni-corn
Copy link
Contributor

heya!

the build is nearly working for me, but auto-patchelf is not:

    libtasn1.so.6 -> found: /nix/store/2q56iahyx3ylqxnaajz44gl6ahp03n40-libtasn1-4.20.0/lib
    libgbm.so.1 -> found: /nix/store/zhw81jsm03gwgj7mcqcr655m25qsn6gk-mesa-libgbm-25.1.0/lib
    libdrm.so.2 -> found: /nix/store/p2ras15qclfyq0bqwiq9kg2h90kcx29h-libdrm-2.4.124/lib
    libstdc++.so.6 -> found: /nix/store/l7d6vwajpfvgsd3j4cr25imd1mzb7d1d-gcc-14.3.0-lib/lib
    libgcc_s.so.1 -> found: /nix/store/h8x8m2vcaqd13sm794q5l3yrynbf3h0q-gcc-14.3.0-libgcc/lib
setting RPATH to: /nix/store/dv9s0nwqlkfs3y6d2y609g4yb7q4vw29-playwright-webkit/minibrowser-wpe/lib:/nix/store/8j6yqx8qfl0g1nwbshq3502hzv36gai6-glib-2.84.2/lib:/nix/store/2s3hvaaw>
searching for dependencies of /nix/store/dv9s0nwqlkfs3y6d2y609g4yb7q4vw29-playwright-webkit/minibrowser-wpe/lib/libwpe-1.0.so.1.9.3
    libxkbcommon.so.0 -> found: /nix/store/dxh4x7x96lfadv500bdw3m2b3h4a3vwa-libxkbcommon-1.10.0/lib
    libstdc++.so.6 -> found: /nix/store/l7d6vwajpfvgsd3j4cr25imd1mzb7d1d-gcc-14.3.0-lib/lib
    libgcc_s.so.1 -> found: /nix/store/h8x8m2vcaqd13sm794q5l3yrynbf3h0q-gcc-14.3.0-libgcc/lib
setting RPATH to: /nix/store/dxh4x7x96lfadv500bdw3m2b3h4a3vwa-libxkbcommon-1.10.0/lib:/nix/store/l7d6vwajpfvgsd3j4cr25imd1mzb7d1d-gcc-14.3.0-lib/lib:/nix/store/h8x8m2vcaqd13sm794q>
auto-patchelf: 2 dependencies could not be satisfied
error: auto-patchelf could not satisfy dependency libxml2.so.2 wanted by /nix/store/dv9s0nwqlkfs3y6d2y609g4yb7q4vw29-playwright-webkit/minibrowser-wpe/bin/.MiniBrowser-wrapped
error: auto-patchelf could not satisfy dependency libxml2.so.2 wanted by /nix/store/dv9s0nwqlkfs3y6d2y609g4yb7q4vw29-playwright-webkit/minibrowser-wpe/lib/libWPEWebKit-2.0.so.1.6.0
auto-patchelf failed to find all the required dependencies.
Add the missing dependencies to --libs or use `--ignore-missing="foo.so.1 bar.so etc.so"`.

@kalekseev
Copy link
Contributor Author

heya!

the build is nearly working for me, but auto-patchelf is not:

    libtasn1.so.6 -> found: /nix/store/2q56iahyx3ylqxnaajz44gl6ahp03n40-libtasn1-4.20.0/lib
    libgbm.so.1 -> found: /nix/store/zhw81jsm03gwgj7mcqcr655m25qsn6gk-mesa-libgbm-25.1.0/lib
    libdrm.so.2 -> found: /nix/store/p2ras15qclfyq0bqwiq9kg2h90kcx29h-libdrm-2.4.124/lib
    libstdc++.so.6 -> found: /nix/store/l7d6vwajpfvgsd3j4cr25imd1mzb7d1d-gcc-14.3.0-lib/lib
    libgcc_s.so.1 -> found: /nix/store/h8x8m2vcaqd13sm794q5l3yrynbf3h0q-gcc-14.3.0-libgcc/lib
setting RPATH to: /nix/store/dv9s0nwqlkfs3y6d2y609g4yb7q4vw29-playwright-webkit/minibrowser-wpe/lib:/nix/store/8j6yqx8qfl0g1nwbshq3502hzv36gai6-glib-2.84.2/lib:/nix/store/2s3hvaaw>
searching for dependencies of /nix/store/dv9s0nwqlkfs3y6d2y609g4yb7q4vw29-playwright-webkit/minibrowser-wpe/lib/libwpe-1.0.so.1.9.3
    libxkbcommon.so.0 -> found: /nix/store/dxh4x7x96lfadv500bdw3m2b3h4a3vwa-libxkbcommon-1.10.0/lib
    libstdc++.so.6 -> found: /nix/store/l7d6vwajpfvgsd3j4cr25imd1mzb7d1d-gcc-14.3.0-lib/lib
    libgcc_s.so.1 -> found: /nix/store/h8x8m2vcaqd13sm794q5l3yrynbf3h0q-gcc-14.3.0-libgcc/lib
setting RPATH to: /nix/store/dxh4x7x96lfadv500bdw3m2b3h4a3vwa-libxkbcommon-1.10.0/lib:/nix/store/l7d6vwajpfvgsd3j4cr25imd1mzb7d1d-gcc-14.3.0-lib/lib:/nix/store/h8x8m2vcaqd13sm794q>
auto-patchelf: 2 dependencies could not be satisfied
error: auto-patchelf could not satisfy dependency libxml2.so.2 wanted by /nix/store/dv9s0nwqlkfs3y6d2y609g4yb7q4vw29-playwright-webkit/minibrowser-wpe/bin/.MiniBrowser-wrapped
error: auto-patchelf could not satisfy dependency libxml2.so.2 wanted by /nix/store/dv9s0nwqlkfs3y6d2y609g4yb7q4vw29-playwright-webkit/minibrowser-wpe/lib/libWPEWebKit-2.0.so.1.6.0
auto-patchelf failed to find all the required dependencies.
Add the missing dependencies to --libs or use `--ignore-missing="foo.so.1 bar.so etc.so"`.

I believe this problem was fixed in master #418639

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 21, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jul 21, 2025
@kalekseev
Copy link
Contributor Author

the patch included into #427631

@kalekseev kalekseev closed this Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: playwright-driver.browsers

5 participants