-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
nixos/nextcloud: Allow disabling initial admin user creation on Nextcloud >= 32 #418378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/nextcloud: Allow disabling initial admin user creation on Nextcloud >= 32 #418378
Conversation
2458811 to
c224e48
Compare
|
Rebased and included #439771 to fix the occ env vars problem. |
c224e48 to
585b061
Compare
|
This PR can already be reviewed and tested. Once satisfied I will remove the wip commit used for testing and we can merge it even before the release of 32. |
Is there a particular reason to merge this before? |
|
Not really, just that there is no time to wait after the 32 release :) |
Ma27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Would prefer to merge this together with the nextcloud 32 introduction.
585b061 to
5382906
Compare
|
Rebased onto #446632, so marking as draft until it is merged. |
5382906 to
02569b4
Compare
|
Finally ready to be merged :) |
…loud >= 32 With nextcloud/server#53212 it is not longer necessary to specify a username and password for an initial admin account during installation.
02569b4 to
e739c5d
Compare
|
@Ma27 friendly ping :) |
Since I forgot to respond: that's fine by me. |
|
FYI: While testing my personal infra with 25.11 I noticed this feature breaks notify_push until a user is created, but I made a fix: nextcloud/notify_push#667 |
With nextcloud/server#53212 it is not longer necessary to specify a username and password for an initial admin account during installation.
This needs a solution for #412675 in order to be able to create the adminuser through nextcloud-occ.
I will make it a draft for now due to the occ env var problem, but we can already merge it before Nextcloud 32 is released, as the logic checks for a compatible version.
The WIP commit is there to test the feature locally, because a daily build of the master branch has to be used for this unreleased feature.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.