Skip to content

Conversation

@provokateurin
Copy link
Member

With nextcloud/server#53212 it is not longer necessary to specify a username and password for an initial admin account during installation.

This needs a solution for #412675 in order to be able to create the adminuser through nextcloud-occ.

I will make it a draft for now due to the occ env var problem, but we can already merge it before Nextcloud 32 is released, as the logic checks for a compatible version.

The WIP commit is there to test the feature locally, because a daily build of the master branch has to be used for this unreleased feature.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 6, 2025
@provokateurin provokateurin force-pushed the nixos-nextcloud-disable-admin-user branch from 2458811 to c224e48 Compare September 3, 2025 07:55
@provokateurin
Copy link
Member Author

Rebased and included #439771 to fix the occ env vars problem.
I also found a crash with this new feature: nextcloud/photos#3148

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 3, 2025
@provokateurin provokateurin force-pushed the nixos-nextcloud-disable-admin-user branch from c224e48 to 585b061 Compare September 4, 2025 06:33
@provokateurin provokateurin marked this pull request as ready for review September 4, 2025 06:34
@provokateurin
Copy link
Member Author

This PR can already be reviewed and tested. Once satisfied I will remove the wip commit used for testing and we can merge it even before the release of 32.

@Ma27
Copy link
Member

Ma27 commented Sep 4, 2025

This PR can already be reviewed and tested. Once satisfied I will remove the wip commit used for testing and we can merge it even before the release of 32.

Is there a particular reason to merge this before?
For me, it'd be perfectly fine to merge this together with the introduction of v32.

@provokateurin
Copy link
Member Author

Not really, just that there is no time to wait after the 32 release :)
I'm also fine just having it reviewed now, wait for the release and then rebase to have the tests validate it's working with the release as well.

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Would prefer to merge this together with the nextcloud 32 introduction.

@provokateurin provokateurin force-pushed the nixos-nextcloud-disable-admin-user branch from 585b061 to 5382906 Compare September 27, 2025 12:57
@provokateurin
Copy link
Member Author

Rebased onto #446632, so marking as draft until it is merged.

@provokateurin provokateurin marked this pull request as draft September 27, 2025 12:57
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Sep 27, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 28, 2025
@provokateurin provokateurin mentioned this pull request Oct 6, 2025
13 tasks
@provokateurin provokateurin force-pushed the nixos-nextcloud-disable-admin-user branch from 5382906 to 02569b4 Compare October 9, 2025 20:06
@provokateurin provokateurin marked this pull request as ready for review October 9, 2025 20:06
@provokateurin
Copy link
Member Author

Finally ready to be merged :)

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 8.has: changelog This PR adds or changes release notes labels Oct 9, 2025
…loud >= 32

With nextcloud/server#53212 it is not longer necessary to specify a username and password for an initial admin account during installation.
@provokateurin provokateurin force-pushed the nixos-nextcloud-disable-admin-user branch from 02569b4 to e739c5d Compare October 13, 2025 18:47
@provokateurin provokateurin requested a review from Ma27 October 13, 2025 18:47
@provokateurin
Copy link
Member Author

@Ma27 friendly ping :)

@Ma27 Ma27 added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit c3615b0 Oct 27, 2025
30 of 31 checks passed
@provokateurin provokateurin deleted the nixos-nextcloud-disable-admin-user branch October 27, 2025 11:30
@Ma27
Copy link
Member

Ma27 commented Oct 27, 2025

Hm so this is a bit more complex than I like, because it's an interaction between the stateVersion and package version. I think we can just save the removal for 26.05, because nextcloud31 will be removed at that point.

Since I forgot to respond: that's fine by me.

@provokateurin
Copy link
Member Author

FYI: While testing my personal infra with 25.11 I noticed this feature breaks notify_push until a user is created, but I made a fix: nextcloud/notify_push#667
Let's hope it gets merged and released soon, so this works correctly with notify_push here.

@provokateurin
Copy link
Member Author

^ Fixed in v1.2.1: #458101 CC @Ma27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants