Skip to content

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Mar 31, 2025

  • Improve handling of query results containing null values for the error field. (#512)
  • Fix accessing spooled segments on S3 when authentication to the Trino cluster is used. (#525)
  • Simplify segment cursor API to make it easier to iterate over spooled segments. (#525)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

flokli added 2 commits March 31, 2025 18:51
* Improve handling of query results containing `null` values for
  the error field.
  ([NixOS#512](trinodb/trino-python-client#512))
* Fix accessing spooled segments on S3 when authentication to the
  Trino cluster is used.
  ([NixOS#525](trinodb/trino-python-client#525))
* Simplify `segment` cursor API to make it easier to iterate over spooled
  segments.
  ([NixOS#525](trinodb/trino-python-client#525))
@flokli flokli requested a review from cpcloud March 31, 2025 18:03
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 31, 2025
@flokli
Copy link
Contributor Author

flokli commented Mar 31, 2025

--------- Report for 'aarch64-linux' ---------
4 packages built:
python312Packages.trino-python-client python312Packages.trino-python-client.dist python313Packages.trino-python-client python313Packages.trino-python-client.dist

nixpkgs-review result

Generated using nixpkgs-review.
Command: nixpkgs-review pr 394971

aarch64-linux

✅ 4 packages built:
  • python312Packages.trino-python-client
  • python312Packages.trino-python-client.dist
  • python313Packages.trino-python-client
  • python313Packages.trino-python-client.dist

@flokli flokli requested a review from GaetanLepage April 24, 2025 15:57
@GaetanLepage GaetanLepage merged commit b3bf482 into NixOS:master Apr 24, 2025
27 checks passed
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 394971


x86_64-linux

✅ 4 packages built:
  • python312Packages.trino-python-client
  • python312Packages.trino-python-client.dist
  • python313Packages.trino-python-client
  • python313Packages.trino-python-client.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.trino-python-client
  • python312Packages.trino-python-client.dist
  • python313Packages.trino-python-client
  • python313Packages.trino-python-client.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.trino-python-client
  • python312Packages.trino-python-client.dist
  • python313Packages.trino-python-client
  • python313Packages.trino-python-client.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.trino-python-client
  • python312Packages.trino-python-client.dist
  • python313Packages.trino-python-client
  • python313Packages.trino-python-client.dist

@flokli flokli deleted the trino-bump branch April 24, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants