Skip to content

Conversation

@aqrln
Copy link
Member

@aqrln aqrln commented Oct 15, 2024

Update the following packages:

  • prisma-engines: 5.18.0 -> 5.21.0
  • prisma: 5.18.0 -> 5.21.0

Fixes: #348732

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aqrln aqrln added 8.has: package (update) This PR updates a package to a newer version 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 11.by: upstream-developer This issue or PR was created by the developer of packaged software. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels Oct 15, 2024
@ofborg ofborg bot requested a review from tomhoule October 15, 2024 18:48
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 15, 2024
@donovanglover
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348844


x86_64-linux

✅ 4 packages built:
  • documenso
  • pingvin-share.backend
  • prisma
  • prisma-engines

@donovanglover
Copy link
Member

Thank you! I am getting 5.19.1 for prisma --version and wanted to make sure that it's not an issue.

.cache/nixpkgs-review/pr-348844 ❄️ >>> PRISMA_SCHEMA_ENGINE_BINARY="/nix/store/6clyqkisnl9a142d3blx6mxp1mhxwcnm-prisma-engines-5.21.0/bin/schema-engine" PRISMA_QUERY_ENGINE_BINARY="/nix/store/6clyqkisnl9a142d3blx6mxp1mhxwcnm-prisma-engines-5.21.0/bin/query-engine" PRISMA_QUERY_ENGINE_LIBRARY="/nix/store/6clyqkisnl9a142d3blx6mxp1mhxwcnm-prisma-engines-5.21.0/lib/libquery_engine.node" prisma --version
prisma:warn Prisma failed to detect the libssl/openssl version to use, and may not work as expected. Defaulting to "openssl-1.1.x".
Please manually install OpenSSL and try installing Prisma again.
prisma:warn Prisma failed to detect the libssl/openssl version to use, and may not work as expected. Defaulting to "openssl-1.1.x".
Please manually install OpenSSL and try installing Prisma again.
prisma                  : 5.19.1
@prisma/client          : Not found
Computed binaryTarget   : linux-nixos
Operating System        : linux
Architecture            : x64
Node.js                 : v20.17.0
Query Engine (Node-API) : libquery-engine 0000000000000000000000000000000000000000 (at ../../../../../nix/store/6clyqkisnl9a142d3blx6mxp1mhxwcnm-prisma-engines-5.21.0/lib/libquery_engine.node, resolved by PRISMA_QUERY_ENGINE_LIBRARY)
Schema Engine           : schema-engine-cli 0000000000000000000000000000000000000000 (at ../../../../../nix/store/6clyqkisnl9a142d3blx6mxp1mhxwcnm-prisma-engines-5.21.0/bin/schema-engine, resolved by PRISMA_SCHEMA_ENGINE_BINARY)
Schema Wasm             : @prisma/prisma-schema-wasm 5.19.1-2.69d742ee20b815d88e17e54db4a2a7a3b30324e3
Default Engines Hash    : 69d742ee20b815d88e17e54db4a2a7a3b30324e3
Studio                  : 0.502.0

Copy link
Contributor

@hehongbo hehongbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and solves #348732 as well. Thanks!

@hehongbo
Copy link
Contributor

I am getting 5.19.1 for prisma --version and wanted to make sure that it's not an issue.

@donovanglover That's your prisma (Prisma CLI) version. In my case it shows 5.21.0 without problem, so I wonder if you have another prisma in your PATH.

[root@nixos:~/nixpkgs]# nix build --no-link --print-out-paths -L "/root/nixpkgs/#legacyPackages.x86_64-linux.nodePackages.prisma"
/nix/store/fs1h6i0fq4497lgfbcfkvaw56751gg39-prisma-5.21.0

[root@nixos:~/nixpkgs]# /nix/store/fs1h6i0fq4497lgfbcfkvaw56751gg39-prisma-5.21.0/bin/prisma --version
prisma:warn Prisma failed to detect the libssl/openssl version to use, and may not work as expected. Defaulting to "openssl-1.1.x".
Please manually install OpenSSL and try installing Prisma again.
prisma:warn Prisma failed to detect the libssl/openssl version to use, and may not work as expected. Defaulting to "openssl-1.1.x".
Please manually install OpenSSL and try installing Prisma again.
prisma                  : 5.21.0
@prisma/client          : Not found
Computed binaryTarget   : linux-nixos
Operating System        : linux
Architecture            : x64
Node.js                 : v20.17.0
Query Engine (Node-API) : libquery-engine 0000000000000000000000000000000000000000 (at ../../nix/store/6clyqkisnl9a142d3blx6mxp1mhxwcnm-prisma-engines-5.21.0/lib/libquery_engine.node, resolved by PRISMA_QUERY_ENGINE_LIBRARY)
Schema Engine           : schema-engine-cli 0000000000000000000000000000000000000000 (at ../../nix/store/6clyqkisnl9a142d3blx6mxp1mhxwcnm-prisma-engines-5.21.0/bin/schema-engine, resolved by PRISMA_SCHEMA_ENGINE_BINARY)
Schema Wasm             : @prisma/prisma-schema-wasm 5.21.0-36.08713a93b99d58f31485621c634b04983ae01d95
Default Engines Hash    : 08713a93b99d58f31485621c634b04983ae01d95
Studio                  : 0.503.0

@aqrln
Copy link
Member Author

aqrln commented Oct 16, 2024

Yep, pointing an older version of the CLI to the newer engines won't change the version of the CLI.

If you nix-build -A prisma && ./result/bin/prisma version, you'll see 5.21.0 as expected. If your prisma is installed with npm, you need to update it that way as well.

@aqrln aqrln added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 16, 2024
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 5.21.0 now thanks! LGTM

@aqrln aqrln added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 16, 2024
@donovanglover donovanglover merged commit 4cd8108 into NixOS:master Oct 16, 2024
@aqrln aqrln deleted the prisma-5.21.0 branch October 16, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 11.by: upstream-developer This issue or PR was created by the developer of packaged software. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: prisma-engines

3 participants