Skip to content

binaryen: 118 -> 119 #340130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gracicot wants to merge 1 commit into from
Closed

binaryen: 118 -> 119 #340130

gracicot wants to merge 1 commit into from

Conversation

@gracicot
Copy link
Contributor

@gracicot gracicot commented Sep 6, 2024 •
edited
Loading

Description of changes

This MR updates binaryen to version 119.

It fixes an issue where emscripten 3.1.64 would call the binaryen executable with a invalid cmd argument that was added but not yet released (WebAssembly/binaryen#6907)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from asppsa and willcohen September 6, 2024 17:52
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 6, 2024
@nixos-discourse
Copy link

nixos-discourse commented Sep 11, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4566

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 12, 2024
@fabianhjr
Copy link
Member

fabianhjr commented Sep 13, 2024

@ofborg build binaryen

@fabianhjr
Copy link
Member

fabianhjr commented Sep 13, 2024

Result of nixpkgs-review pr 340130 run on x86_64-linux 1

1 package marked as broken and skipped:
  • magnetophonDSP.ConstantDetuneChorus
38 packages failed to build:
  • binaryen
  • emscripten
  • faust (faust2)
  • faust2alqt
  • faust2alsa
  • faust2csound
  • faust2firefox
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faust2sc
  • faustPhysicalModeling
  • faustlive
  • guitarix
  • kapitonov-plugins-pack
  • lldap
  • magnetophonDSP.CharacterCompressor
  • magnetophonDSP.CompBus
  • magnetophonDSP.LazyLimiter
  • magnetophonDSP.MBdistortion
  • magnetophonDSP.RhythmDelay
  • magnetophonDSP.VoiceOfFaust
  • magnetophonDSP.faustCompressors
  • magnetophonDSP.pluginUtils
  • magnetophonDSP.shelfMultiBand
  • mooSpace
  • open-music-kontrollers.mephisto
  • pagefind
  • rerun
  • tambura
  • teleport (teleport_16)
  • teleport.client (teleport_16.client)
  • teleport_15
  • teleport_15.client
  • tinygo
  • vlang

fabianhjr
fabianhjr requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@fabianhjr fabianhjr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://hydra.nixos.org/eval/1808819?filter=binaryen&compare=1808812&full=

Binaryen currently builds on 118 but doesn't after this upgrade on x86_64-linux UnU

@willcohen willcohen mentioned this pull request Sep 22, 2024
Merged
13 tasks
@willcohen
Copy link
Contributor

willcohen commented Sep 22, 2024

Added the binaryen change from here in #343743 for the next emscripten version bump.

@gracicot
Copy link
Contributor Author

gracicot commented Sep 23, 2024

@willcohen I will wait for you to merge it before closing this one then

@willcohen
Copy link
Contributor

willcohen commented Sep 23, 2024

I’m having the build issue too there, actually. Any sense of what’s causing it? Hard for me to diagnose on Mac.

@gracicot
Copy link
Contributor Author

gracicot commented Sep 23, 2024

@willcohen I have a linux machine, I'll take a look today

@gracicot gracicot force-pushed the gracicot/binaryen-119 branch from bd298fc to a2d176d Compare September 23, 2024 15:25
@ofborg ofborg bot requested a review from willcohen September 23, 2024 16:46
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 25, 2024
@gracicot
Copy link
Contributor Author

gracicot commented Oct 3, 2024

Sorry for the silence. I investigated but haven't found much, I'm not sure I'm gonna have soon time available to followup this PR as I moved project recently.

@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Oct 29, 2024
@willcohen
Copy link
Contributor

willcohen commented Nov 23, 2024

Thanks to @wirew0rm and @uncenter, #343743 looks unblocked at this point!

@wirew0rm
Copy link
Contributor

wirew0rm commented Dec 2, 2024

#343743 is now merged and updated binaryen to 119

@wirew0rm wirew0rm closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianhjr fabianhjr fabianhjr requested changes

@asppsa asppsa Awaiting requested review from asppsa

@willcohen willcohen Awaiting requested review from willcohen

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gracicot @nixos-discourse @fabianhjr @willcohen @wirew0rm @wegank