Skip to content

nix-doc: fix build for Rust 1.79+ #330923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2024
Merged

nix-doc: fix build for Rust 1.79+ #330923

merged 2 commits into from
Jul 29, 2024

Conversation

@philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Jul 29, 2024 •
edited
Loading

Description of changes

As of Rust 1.79+ (turned on in a5b2fe7) relro-level is now stable. 🎉

This means nix-doc (which uses this option in its unstable form) needs to pass through -C instead of -Z.

Also, sign up to maintain the tool (unmaintained since #323887). I use it a lot!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@philiptaron
nix-doc: fix build for Rust 1.79+
bb65f97 
As of Rust 1.79+ (turned on in a5b2fe7) `relro-level` is now stable. 🎉

This means `nix-doc` (which uses this option in its unstable form) needs to pass through `-C` instead of `-Z`.
@philiptaron
nix-doc: sign up to maintain this tool in nixpkgs
e430cf4 
I use it a lot.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jul 29, 2024
@lf- lf- merged commit 0a1650c into NixOS:master Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

@emilazy emilazy Awaiting requested review from emilazy

@drupol drupol Awaiting requested review from drupol

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philiptaron @lf-