Skip to content

python312Packages.spylls: init at 0.1.5#295371

Merged
natsukium merged 2 commits intoNixOS:masterfrom
ViZiD:spylls
Apr 28, 2024
Merged

python312Packages.spylls: init at 0.1.5#295371
natsukium merged 2 commits intoNixOS:masterfrom
ViZiD:spylls

Conversation

@ViZiD
Copy link
Contributor

@ViZiD ViZiD commented Mar 12, 2024

Description of changes

Pure Python spell-checker, (almost) full port of Hunspell
https://github.com/zverok/spylls

https://github.com/zverok/spylls/blob/master/CHANGELOG.rst

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 12, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 12, 2024
@ViZiD ViZiD requested review from fabaff and natsukium March 14, 2024 15:56
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/107

@ViZiD ViZiD requested review from natsukium and removed request for natsukium March 24, 2024 10:41
Comment on lines 28 to 29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Then please fetch the patch. (or replace --replace with newer --replace-fail)
https://nixos.org/manual/nixpkgs/unstable/#fun-substitute-replace-fail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViZiD ViZiD requested a review from natsukium March 26, 2024 12:49
@ViZiD ViZiD changed the title python311Packages.spylls: init at 0.1.5 python312Packages.spylls: init at 0.1.5 Mar 27, 2024
Comment on lines 36 to 44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [
pytest # hack for fix error: `pytest not installed`
pythonRelaxDepsHook
];
pythonRelaxDeps = [
"pytest"
];

I can't reproduce such an error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natsukium this error is only in version 0.1.5
Can you explain how pythonRelaxDeps work, if a package needs another package in version 0.2.0, but the latest version of the package is 0.2.5, do I need to commit version 0.2.0 and then 0.2.5?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if a package needs another package in version 0.2.0, but the latest version of the package is 0.2.5, do I need to commit version 0.2.0 and then 0.2.5?

No. pythonRelaxDepsHook simply ignores upstream version constraints.
It does not reference previous versions.

@ViZiD
Copy link
Contributor Author

ViZiD commented Apr 20, 2024

@sikmir @Aleksanaa @natsukium

@ViZiD ViZiD requested a review from azahi April 24, 2024 14:21
@natsukium natsukium merged commit 485534a into NixOS:master Apr 28, 2024
@ViZiD ViZiD deleted the spylls branch April 28, 2024 09:51
WGUNDERWOOD pushed a commit to WGUNDERWOOD/nixpkgs that referenced this pull request Jul 6, 2024
* python312Packages.spylls: init at 0.1.5

* python312Packages.spylls: 0.1.5 -> 0.1.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants