Skip to content

Revert "pkgs.formats.toml: fix TOML semantics by upgrading tomlkit"#245763

Merged
0x4A6F merged 1 commit intomasterfrom
revert-245440-pin-tomlkit
Jul 27, 2023
Merged

Revert "pkgs.formats.toml: fix TOML semantics by upgrading tomlkit"#245763
0x4A6F merged 1 commit intomasterfrom
revert-245440-pin-tomlkit

Conversation

@mweinelt
Copy link
Copy Markdown
Member

Reverts #245440

Caused too many rebuilds, broke pylint and by extension all nixos tests, and as such created a channel blocker.

@mweinelt mweinelt added the 1.severity: channel blocker Blocks a channel label Jul 27, 2023
@mweinelt mweinelt requested a review from infinisil as a code owner July 27, 2023 16:56
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 27, 2023
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Jul 27, 2023

Yes, I think it's best to revert for now. Reopened after resolving the big regression and against staging branch.

@mweinelt
Copy link
Copy Markdown
Member Author

Might take this change into python-updates, if I can get pylint to work.

@ofborg ofborg bot requested review from jbaum98 and jonringer July 27, 2023 17:14
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 27, 2023
@0x4A6F 0x4A6F merged commit 1fb5607 into master Jul 27, 2023
@mweinelt mweinelt deleted the revert-245440-pin-tomlkit branch July 27, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants