gitea-actions-runner: 0.1.8 -> 0.2.3 #243539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
emilylange
requested changes
Jul 15, 2023
Member
emilylange
left a comment
emilylange
left a comment
There was a problem hiding this comment.
Upstream seems to have changed the following ldflag from
"-X gitea.com/gitea/act_runner/internal/pkg/ver.version=${version}"
to
"-X gitea.com/gitea/act_runner/internal/pkg/ver.version=v${version}"
in
https://gitea.com/gitea/act_runner/pulls/201/files#diff-836efb6e25a091dcb4ff8e1dbb2f0be6a5cbf14c
Can you change this as well, please?
(GitHub won't let me comment on the line directly)
emilylange
approved these changes
Jul 16, 2023
Member
emilylange
left a comment
emilylange
left a comment
There was a problem hiding this comment.
Thanks.
I went ahead and manually verified that the runner registers properly.
Really looking forward to merging #228815 soon (as v1.20 seems to be around the corner).
| "-s" | ||
| "-w" | ||
| "-X gitea.com/gitea/act_runner/internal/pkg/ver.version=${version}" | ||
| "-X gitea.com/gitea/act_runner/internal/pkg/ver.version=v${version}" |
Member
There was a problem hiding this comment.
Suggested change
| "-X gitea.com/gitea/act_runner/internal/pkg/ver.version=v${version}" | |
| "-X gitea.com/gitea/act_runner/internal/pkg/ver.version=${src.rev}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff: https://gitea.com/gitea/act_runner/compare/v0.1.8...v0.2.3
Changelog: https://gitea.com/gitea/act_runner/releases/tag/v0.2.3
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)