Skip to content

python310Packages.requests-mock: 1.10.0 -> 1.11.0#241074

Closed
tjni wants to merge 127 commits intoNixOS:masterfrom
tjni:requests-mock
Closed

python310Packages.requests-mock: 1.10.0 -> 1.11.0#241074
tjni wants to merge 127 commits intoNixOS:masterfrom
tjni:requests-mock

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Jul 2, 2023

Description of changes

https://github.com/jamielennox/requests-mock/releases/tag/1.11.0

There are a couple of changes that warrant an explanation:

  1. testrepository was removed in Remove testrepository dependency jamielennox/requests-mock#229, so the postPatch hook can be removed.

  2. The mock dependency is no longer needed on Python >= 3.4, so it has been removed.

  3. Tests are now run properly by copying what is done in the project's GitHub actions here.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

SuperSandro2000 and others added 30 commits May 22, 2023 19:56
This fixes issues with environment.noXLibs
This is not actually a compile time dependency and sharing libs is not
worth the it because libva compiles in just a few seconds
this is the new esr release
see nss latest updates for changelogs
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 2, 2023
@tjni tjni requested review from a team, ajs124, figsoda, lukegb, marsam, mweinelt, winterqt and zowoq as code owners July 2, 2023 09:37
@tjni tjni closed this Jul 2, 2023
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Jul 2, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Jul 2, 2023

Arghh, how do I keep messing up the rebase.

@tjni tjni deleted the requests-mock branch July 2, 2023 09:37
@tjni tjni removed request for a team, ajs124, figsoda, lukegb, marsam, mweinelt, winterqt and zowoq July 2, 2023 09:40
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jul 2, 2023

How do you rebase? Probably not interactively, or else you would notice this earlier.

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Jul 2, 2023

Yeah, I just directly follow the commands from the contributing guide. I had realized I needed to run a git fetch upstream before doing so but I must have forgotten to update something else too this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: vim Advanced text editor 8.has: module (update) This PR changes an existing module in `nixos/`

Projects

None yet

Development

Successfully merging this pull request may close these issues.