Skip to content

python310Packages.requests-toolbelt: 0.10.1 -> 1.0.0#240796

Closed
tjni wants to merge 1 commit intoNixOS:stagingfrom
tjni:requests-toolbelt
Closed

python310Packages.requests-toolbelt: 0.10.1 -> 1.0.0#240796
tjni wants to merge 1 commit intoNixOS:stagingfrom
tjni:requests-toolbelt

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Jun 30, 2023

Description of changes

From the release notes:

Breaking Changes
Removed Google App Engine support to allow using urllib3 2.0

Fixed Bugs
Ensured the test suite no longer reaches the Internet

Miscellaneous
Added explicit support for Python 3.11

I think that the tests can be reenabled because the certificate expiration issue that was reported in #147776 should be fixed now that upstream uses trustme.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 30, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 30, 2023
@tjni tjni changed the base branch from master to staging June 30, 2023 21:23
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2408

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 10, 2023
@SuperSandro2000
Copy link
Copy Markdown
Member

included in #244135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants