Skip to content

python3Packages.httpx: 0.23.3 -> 0.24.1#237274

Closed
bhipple wants to merge 2 commits intoNixOS:stagingfrom
bhipple:u/httpx
Closed

python3Packages.httpx: 0.23.3 -> 0.24.1#237274
bhipple wants to merge 2 commits intoNixOS:stagingfrom
bhipple:u/httpx

Conversation

@bhipple
Copy link
Copy Markdown
Contributor

@bhipple bhipple commented Jun 12, 2023 •
edited
Loading

Description of changes

https://github.com/encode/httpx/blob/master/CHANGELOG.md

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 12, 2023
@ofborg ofborg bot requested review from costrouc and fabaff June 12, 2023 03:09
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 12, 2023
@tjni tjni mentioned this pull request Jun 14, 2023
Merged
12 tasks
@tjni
Copy link
Copy Markdown
Contributor

tjni commented Jun 14, 2023

Would you mind adding a commit updating pytest-httpx to v0.22.0? It seems intended to move in lockstep with httpx.

This was referenced Jun 14, 2023
Merged
Merged
Closed
Merged
Merged
@tjni
Copy link
Copy Markdown
Contributor

tjni commented Jun 16, 2023 •
edited
Loading

As noted in #238033, frogmouth is also affected and will need its dependency on httpx to be relaxed.

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jun 16, 2023

Would you mind adding a commit updating pytest-httpx to v0.22.0? It seems intended to move in lockstep with httpx.

Please also update httpcore for the same reason

@ofborg ofborg bot requested a review from risicle June 18, 2023 12:19
@bhipple
Copy link
Copy Markdown
Contributor Author

bhipple commented Jun 18, 2023 •
edited
Loading

Thank you for pushing this along, @mweinelt! It's much appreciated. I've had a really busy week at work so I haven't had time to follow-up, and probably won't have much this week either.

@bhipple
Copy link
Copy Markdown
Contributor Author

bhipple commented Jun 18, 2023

I added the relaxed deps on frogmouth as requested.

@ofborg ofborg bot requested a review from figsoda June 18, 2023 16:52
@figsoda
Copy link
Copy Markdown
Member

figsoda commented Jun 27, 2023

#240135 updates frogmouth with updates its httpx dependency

@bhipple
Copy link
Copy Markdown
Contributor Author

bhipple commented Jul 3, 2023

I rebased away the changes that have already been merged. I think the rest is now good for review?

dropping b1aeda150799209be82285f9fdf86d291200abbf python310Packages.pytest-httpx: 0.21.3 -> 0.22.0 -- patch contents already upstream
dropping 7a81cb6803390d183924df84f420eded64288ea5 python310Packages.frogmouth: relax dependency on httpx -- patch contents already upstream

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Jul 18, 2023

included in #244135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff Awaiting requested review from fabaff

@costrouc costrouc Awaiting requested review from costrouc

@risicle risicle Awaiting requested review from risicle

@figsoda figsoda Awaiting requested review from figsoda

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

Python batch upgrade
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bhipple @tjni @mweinelt @figsoda @SuperSandro2000