Skip to content

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 11, 2021

Motivation for this change

ChangeLog: https://nextcloud.com/changelog/#22-2-1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from bachp, fpletz, globin and schneefux November 11, 2021 23:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 11, 2021
@Ma27 Ma27 merged commit f161fe9 into NixOS:master Nov 12, 2021
@Ma27 Ma27 deleted the bump-nextcloud22 branch November 12, 2021 12:10
@github-actions
Copy link
Contributor

Successfully created backport PR #145624 for release-21.05.

@turion
Copy link
Contributor

turion commented Nov 12, 2021

Note nextcloud/server#29678, it's probably a bad idea to update to 22.2.1 :(

@turion
Copy link
Contributor

turion commented Nov 12, 2021

Not sure whether we should maybe temporarily revert?

@Ma27
Copy link
Member Author

Ma27 commented Nov 12, 2021

The backport shouldn't be merged, of course now. Let's wait a moment and see if they publish a hotfix release (though I didn't have notable performance issues, otherwise I wouldn't have merged in the first place).

Also, if it's known what the problem is, we probably want to just apply a fix?

@turion
Copy link
Contributor

turion commented Nov 12, 2021

The fix is probably coming from nextcloud/server#29682, and it's not clear yet whether there is a hotfix release.

@beardhatcode
Copy link
Contributor

There is a version 22.2.2, which should have fixed the issue. See: nextcloud/server#29682 and #145700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants