Support registration token UIA type#60
Conversation
|
Not entirely sure I haven't missed something, but I couldn't see any other obvious places additions would be needed |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 68.53% 68.56% +0.03%
==========================================
Files 134 134
Lines 4783 4788 +5
==========================================
+ Hits 3278 3283 +5
Misses 1505 1505
Continue to review full report at Codecov.
|
|
So I think this covers everything from the perspective of recognizing the new flow type from the server and also sending the appropriate registration request back. I do know on your MSC proposal, you suggested a validity URL as well. I'm not sure the status of that specific part being included in the final MSC or not, but it might be good to add the piping for that to mtxclient as well. @deepbluev7 , can you verify that I didn't miss anything? You've spent a lot more time on auth flows than I have =D. |
|
@redsky17 Oh I completely forgot about the validity checking endpoint :D |
|
These changes look correct to me. Maybe we are missing something, but we can add that, when the code is actually used in Nheko. The validity checking can be done in a separate PR imo. Thank you! |
MSC3231: matrix-org/matrix-spec-proposals#3231