Merged
Conversation
…sponseFlags param
- Changed the Address field in EventFilter from a single felt.Felt to a slice of felt.Felt to support multiple addresses. - Updated relevant code in readEvents example and events tests to reflect this change.
- Changed the SimulationFlags field in TxnOptions to EstimateFeeFlags - Updated methods and tests to use EstimateFlags instead of SimulationFlags
…ol and update tests
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Collaborator
Author
|
Tests are failing since there's no release from any full-node implementing rpc v0.10.1-rc.2 yet. We'll update the tests when there's a node release available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core RPC method signatures and transaction hashing/encoding, which is broadly breaking for consumers and could affect correctness if flag handling or proof-fact hashing diverges from node behavior.
Overview
Updates the RPC/client APIs to align with Starknet RPC
v0.10.1-rc.2, adding support for proof-related fields and flag-controlled response shapes.Provider methods are extended to accept new flag parameters (
responseFlagsfor block/transaction lookups,traceFlagsforTraceBlockTransactions),EstimateFeeswitches to[]EstimateFeeFlag, and bothSimulateTransactionsandTraceBlockTransactionsnow return wrapper result types that can includeinitial_readswhenRETURN_INITIAL_READSis requested.Transaction/event types are updated accordingly:
InvokeTxnV3gainsProofFacts,BroadcastInvokeTxnV3becomes a distinct struct includingProof/ProofFacts, event filters/subscriptions now accept single-or-multi addresses viaAddressList, and websocket new-tx subscriptions addTags(e.g. include proof facts). Account fee-estimation options and examples/tests/mocks are updated to match the new signatures, and invoke hashing now conditionally incorporatesProofFacts.Written by Cursor Bugbot for commit 11cd4d5. This will update automatically on new commits. Configure here.