feat: add specific return types for BlockWithTxs and BlockWithTxHashes#841
Open
bimakw wants to merge 1 commit intoNethermindEth:mainfrom
Open
feat: add specific return types for BlockWithTxs and BlockWithTxHashes#841bimakw wants to merge 1 commit intoNethermindEth:mainfrom
bimakw wants to merge 1 commit intoNethermindEth:mainfrom
Conversation
Replace interface{} return type with specific interface types:
- BlockWithTxsResult for BlockWithTxs (returns *Block or *PreConfirmedBlock)
- BlockWithTxHashesResult for BlockWithTxHashes (returns *BlockTxHashes or *PreConfirmedBlockTxHashes)
This follows Go's sealed type union pattern with unexported marker methods,
improving type safety and IDE autocomplete while maintaining backward compatibility.
Closes NethermindEth#355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interface{}return type with specific interface types forBlockWithTxsandBlockWithTxHashesBlockWithTxsResultinterface (returns*Blockor*PreConfirmedBlock)BlockWithTxHashesResultinterface (returns*BlockTxHashesor*PreConfirmedBlockTxHashes)This improves type safety and IDE autocomplete while maintaining backward compatibility.
Changes
rpc/types_block.go: Add result interfaces with marker methodsrpc/block.go: Update return typesrpc/provider.go: Update RPCProvider interfaceinternal/tests/mocks/rpcv10mock/rpc.go: Regenerated mockTest plan
go build ./...passesgo test ./rpc/... -run TestBlockWithTxpassesgo vet ./...passesmockgenCloses #355