Merged
Conversation
- Updated the ResBoundsMapToOverallFee function to accept an additional tip parameter, fixing fee calculation accuracy. - Modified related function calls in transaction_test.go and main.go to accommodate the new tip parameter. - Enhanced unit tests for ResBoundsMapToOverallFee to validate behavior with various tip values, ensuring comprehensive coverage of fee scenarios.
thiagodeev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the overall fee calculation to include the tip amount.
Problem:
The utils.ResBoundsMapToOverallFee function was not considering the tip when calculating the overall fee, causing incorrect fee calculations.
Ref: https://docs.starknet.io/learn/protocol/fees#overall-fee
Solution:
Changes:
This ensures the overall fee calculation matches the Starknet fee formula, including the tip component.