Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thiagodeev
reviewed
Oct 7, 2025
.github/workflows/linter.yml
Outdated
| uses: golangci/golangci-lint-action@v8 | ||
| with: | ||
| version: v2.4.0 No newline at end of file | ||
| version: latest |
Collaborator
There was a problem hiding this comment.
I disagree with this change.
Arguments:
- We will be susceptible to a supply chain attack if a future version of the linter is compromised, since our CI will always get the latest release, even though it's compromised.
- Incompatible new versions could break our workflow. E.g.: when golangci v3.0.0 is released, we'll fetch it and break our CI
It's a good practice to use fixed versions and update after
WDYT?
Contributor
Author
There was a problem hiding this comment.
- The attack comes from using
golangci/golangci-lines-action@v8, not from settinglatest. I think it creates more hassle and hurts readability. Take Copilot comments with a pinch of salt. - What's the big deal with out CI breaking when golangci v3.0.0 releases? We then make the decision to update to v3.0.0 or set a different one.
Start to implement the new rules in the lint diff file
…h it - Fix part of the linter errors triggered by it. Others will be fixed in a next commit - Updated changelog with the changes
…erences - Updated changelog to reflect these changes.
thiagodeev
approved these changes
Oct 13, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in [Nubia] Starknet.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.