Skip to content

fix: use ctx param in call to Provider.Nonce #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thiagodeev merged 2 commits into from
Oct 7, 2025
+2 −1
Merged

fix: use ctx param in call to Provider.Nonce #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce34813
fix: use ctx param in call to Provider.Nonce
rodrodros Oct 7, 2025
24ba15a
chore: update changelog to reflect the change
thiagodeev Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
so the output of `TypedData.MarshalJSON()` is exactly as the original JSON.
- Wrong encoding of the `selector` type in the `typedData` pkg for a specific case, when the value was already a hashed selector.
More details in the PR [793](https://github.com/NethermindEth/starknet.go/pull/793).
- Not using the provided `context.Context` in the `account.Nonce` method when calling the `rpc.Nonce` method.

### Dev updates
- New `internal/tests/jsonrpc_spy.go` file containing a `Spy` type for spying JSON-RPC calls in tests. The
Expand Down
2 changes: 1 addition & 1 deletion account/account.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func NewAccount(

// Nonce retrieves the nonce for the account's contract address.
func (account *Account) Nonce(ctx context.Context) (*felt.Felt, error) {
return account.Provider.Nonce(context.Background(), rpc.WithBlockTag("pre_confirmed"), account.Address)
return account.Provider.Nonce(ctx, rpc.WithBlockTag("pre_confirmed"), account.Address)
}

// PrecomputeAccountAddress calculates the precomputed address for an account.
Expand Down
Loading