Skip to content

Fix/wrong omitempty in rpcerror #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thiagodeev merged 4 commits into from
Aug 5, 2025
Merged

Fix/wrong omitempty in rpcerror #776

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79a9927
Don't omitempty for TransactionExecErrData TransactionIndex
tarrencev Aug 1, 2025
4aeb564
refactor: remove omitempty from error struct fields in rpc/errors.go
thiagodeev Aug 5, 2025
dc864b8
Merge branch 'main' into fix/wrong-omitempty-in-rpcerror
thiagodeev Aug 5, 2025
15454ff
chore: update CHANGELOG.md for omitempty tag + v0.13.1 release
thiagodeev Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions rpc/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ func (s StringErrData) ErrorMessage() string {

// Structured type for the ErrCompilationError data
type CompilationErrData struct {
CompilationError string `json:"compilation_error,omitempty"`
CompilationError string `json:"compilation_error"`
}

func (c *CompilationErrData) ErrorMessage() string {
Expand All @@ -346,7 +346,7 @@ func (c *CompilationErrData) ErrorMessage() string {

// Structured type for the ErrContractError data
type ContractErrData struct {
RevertError ContractExecutionError `json:"revert_error,omitempty"`
RevertError ContractExecutionError `json:"revert_error"`
}

func (c *ContractErrData) ErrorMessage() string {
Expand All @@ -355,8 +355,8 @@ func (c *ContractErrData) ErrorMessage() string {

// Structured type for the ErrTransactionExecError data
type TransactionExecErrData struct {
TransactionIndex int `json:"transaction_index,omitempty"`
ExecutionError ContractExecutionError `json:"execution_error,omitempty"`
TransactionIndex int `json:"transaction_index"`
ExecutionError ContractExecutionError `json:"execution_error"`
}

func (t *TransactionExecErrData) ErrorMessage() string {
Expand All @@ -365,7 +365,7 @@ func (t *TransactionExecErrData) ErrorMessage() string {

// Structured type for the ErrTraceStatusError data
type TraceStatusErrData struct {
Status TraceStatus `json:"status,omitempty"`
Status TraceStatus `json:"status"`
}

func (t *TraceStatusErrData) ErrorMessage() string {
Expand All @@ -375,8 +375,8 @@ func (t *TraceStatusErrData) ErrorMessage() string {
// structured error that can later be processed by wallets or sdks
type ContractExecutionError struct {
// the error raised during execution
Message string `json:",omitempty"`
ContractExecErrInner *ContractExecutionErrorInner `json:",omitempty"`
Message string
ContractExecErrInner *ContractExecutionErrorInner
}

func (contractEx *ContractExecutionError) UnmarshalJSON(data []byte) error {
Expand Down
Loading