Skip to content

Bls precompiles: remove MUL #7932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 6, 2025
Merged

Bls precompiles: remove MUL #7932

merged 5 commits into from
Jan 6, 2025

Conversation

@Marchhill
Copy link
Contributor

@Marchhill Marchhill commented Dec 18, 2024 •
edited
Loading

Note: CI not passing since tests are not updated with EIP-2537 changes

Changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Will be tested by devnet 5 state tests.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@Marchhill Marchhill changed the title Bls precompile: remove MUL Bls precompiles: remove MUL Dec 18, 2024
@Marchhill Marchhill requested a review from MarekM25 December 18, 2024 15:33
@Marchhill Marchhill mentioned this pull request Dec 18, 2024
Merged
16 tasks
@Marchhill Marchhill marked this pull request as ready for review December 30, 2024 15:41
@Marchhill Marchhill mentioned this pull request Jan 2, 2025
Closed
@Marchhill Marchhill merged commit ddc7a95 into master Jan 6, 2025
79 checks passed
@Marchhill Marchhill deleted the feature/bls-remove-mul branch January 6, 2025 12:52
rjnrohit pushed a commit that referenced this pull request Jan 11, 2025
@Marchhill @MarekM25 @rjnrohit
Bls precompiles: remove MUL (#7932)
910e471 
Co-authored-by: Marek Moraczyński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Marchhill @MarekM25 @LukaszRozmej