Skip to content

Conversation

@marcindsobczak
Copy link
Contributor

Changes:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

it is already tested, only the performance has increased.

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use a tests for 1-10 rounds for each method (AVX/SSE/Scalar) just to be sure we didn't miss any check

@LukaszRozmej LukaszRozmej merged commit ca460a5 into master Feb 22, 2022
@LukaszRozmej LukaszRozmej deleted the refactor/blake2 branch February 22, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants