Skip to content

Fix additional builder metrics flags #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlegJakushkin merged 6 commits into from
Oct 24, 2023
Merged

Fix additional builder metrics flags #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00ba47b
Update builder metrics flags
cbermudez97 Oct 19, 2023
d032267
fix: update metrics flags
cbermudez97 Oct 19, 2023
b5b1d20
feat: update dashboard tooltips
cbermudez97 Oct 19, 2023
141ce8e
feat: use ethereum package main branch
cbermudez97 Oct 19, 2023
b8d791c
feat: use version 0.6.1 with builder fix
cbermudez97 Oct 20, 2023
b447b2d
chore: merge branch 'main' into metrics-testing
cbermudez97 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 32 additions & 48 deletions scripts/kurtosis/data/grafana/dashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"fiscalYearStartMonth": 0,
"gnetId": 14053,
"graphTooltip": 1,
"id": 3,
"id": 1,
"links": [],
"liveNow": false,
"panels": [
Expand Down Expand Up @@ -67,7 +67,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -116,8 +115,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -174,7 +173,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -223,8 +221,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -282,7 +280,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -332,8 +329,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -391,7 +388,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -440,8 +436,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -496,7 +492,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -545,8 +540,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -589,7 +584,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -638,8 +632,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -695,7 +689,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -744,8 +737,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -800,7 +793,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -849,8 +841,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -893,7 +885,6 @@
"tooltip": false,
"viz": false
},
"insertNulls": false,
"lineInterpolation": "linear",
"lineWidth": 1,
"pointSize": 5,
Expand Down Expand Up @@ -942,8 +933,8 @@
"showLegend": true
},
"tooltip": {
"mode": "single",
"sort": "none"
"mode": "multi",
"sort": "desc"
}
},
"targets": [
Expand Down Expand Up @@ -1026,7 +1017,7 @@
"alertThreshold": true
},
"percentage": false,
"pluginVersion": "10.1.2",
"pluginVersion": "9.5.12",
"pointradius": 5,
"points": false,
"renderer": "flot",
Expand Down Expand Up @@ -1146,7 +1137,7 @@
"alertThreshold": true
},
"percentage": false,
"pluginVersion": "10.1.2",
"pluginVersion": "9.5.12",
"pointradius": 5,
"points": false,
"renderer": "flot",
Expand Down Expand Up @@ -1266,7 +1257,7 @@
"alertThreshold": true
},
"percentage": false,
"pluginVersion": "10.1.2",
"pluginVersion": "9.5.12",
"pointradius": 5,
"points": false,
"renderer": "flot",
Expand Down Expand Up @@ -1398,7 +1389,7 @@
"alertThreshold": true
},
"percentage": false,
"pluginVersion": "10.1.2",
"pluginVersion": "9.5.12",
"pointradius": 5,
"points": false,
"renderer": "flot",
Expand Down Expand Up @@ -1504,7 +1495,7 @@
"alertThreshold": true
},
"percentage": false,
"pluginVersion": "10.1.2",
"pluginVersion": "9.5.12",
"pointradius": 5,
"points": false,
"renderer": "flot",
Expand Down Expand Up @@ -1639,8 +1630,7 @@
"mode": "absolute",
"steps": [
{
"color": "rgb(252, 252, 252)",
"value": null
"color": "rgb(252, 252, 252)"
}
]
},
Expand Down Expand Up @@ -1739,8 +1729,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
}
]
},
Expand Down Expand Up @@ -1841,8 +1830,7 @@
"mode": "absolute",
"steps": [
{
"color": "rgb(255, 255, 255)",
"value": null
"color": "rgb(255, 255, 255)"
}
]
},
Expand Down Expand Up @@ -1919,8 +1907,7 @@
"mode": "absolute",
"steps": [
{
"color": "rgb(255, 255, 255)",
"value": null
"color": "rgb(255, 255, 255)"
}
]
},
Expand Down Expand Up @@ -1997,8 +1984,7 @@
"mode": "absolute",
"steps": [
{
"color": "rgb(255, 255, 255)",
"value": null
"color": "rgb(255, 255, 255)"
}
]
},
Expand Down Expand Up @@ -2193,8 +2179,7 @@
"mode": "absolute",
"steps": [
{
"color": "rgb(255, 255, 255)",
"value": null
"color": "rgb(255, 255, 255)"
}
]
},
Expand Down Expand Up @@ -2271,8 +2256,7 @@
"mode": "absolute",
"steps": [
{
"color": "rgb(255, 255, 255)",
"value": null
"color": "rgb(255, 255, 255)"
}
]
},
Expand Down Expand Up @@ -3456,7 +3440,7 @@
"current": {
"selected": false,
"text": "Prometheus",
"value": "PBFA97CFB590B2093"
"value": "Prometheus"
},
"hide": 0,
"includeAll": false,
Expand Down
2 changes: 1 addition & 1 deletion scripts/kurtosis/main.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#Node: works only with config files local to ./kurtosis/ folder where kurtosis.yml is defined

eth_pkg = import_module(
"github.com/kurtosis-tech/ethereum-package/main.star@0.6.1"
"github.com/kurtosis-tech/ethereum-package/main.star@cbermudez/builder-metrics"
)

def run(plan, file_to_read = "network_params_tmp.json"):
Expand Down
11 changes: 7 additions & 4 deletions scripts/kurtosis/network_params.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@
"--builder.genesis_validators_root=GENESIS_VALIDATORS_ROOT_PLACEHOLDER",
"--miner.extradata=The_Dev_version_of_builder",
"--builder.algotype=greedy",
"--metrics.builder=true"
"--metrics.builder",
"--metrics.expensive"
],
"validator_count": 0,
"el_extra_env_vars": {
Expand All @@ -56,7 +57,10 @@
"mev_flood_image": "flashbots/mev-flood:0.0.9",
"mev_relay_image": "flashbots/mev-boost-relay:0.27",
"mev_boost_image": "flashbots/mev-boost:1.6",
"mev_builder_image": "flashbots/builder:latest"
"mev_builder_image": "flashbots/builder:latest",
"mev_builder_extra_args": [
"--metrics.expensive"
]
},
"additional_services": [
"tx_spammer",
Expand All @@ -75,7 +79,6 @@
"interval_between_transactions": 0.05
},
"grafana_additional_dashboards": [
"github.com/flashbots/builder-startup-script/data/grafana/dashboard.json",
"github.com/flashbots/builder-startup-script/data/grafana"
]
}
}