Support passing/overriding private and public key for --generate-signature option

[mgaberc-biosistemika]

Support passing/overriding private and public key for --generate-signature option. Seems like currently if you want to recreate signature (with --generate-signature parameter) it is required that keys are already stored on the disk.

It would be a useful feature if manually changing the appcast file after signing and need to recreate just the signature.

The command I would like to run:
netsparkle-generate-appcast --generate-signature "path-to-binary" --public-key-override "xy" --private-key-override "xy"

[Deadpikle]

Hi @mgaberc-biosistemika,

That already works exactly as you've described. You can also use environment variables as described in the README to override the keys.

NetSparkle/src/NetSparkle.Tools.AppCastGenerator/Program.cs

Lines 79 to 95 in af3e44f

	if (!string.IsNullOrWhiteSpace(opts.PublicKeyOverride))
	{
	signatureManager.SetPublicKeyOverride(opts.PublicKeyOverride);
	}
	if (!string.IsNullOrWhiteSpace(opts.PrivateKeyOverride))
	{
	signatureManager.SetPrivateKeyOverride(opts.PrivateKeyOverride);
	}
	if (opts.BinaryToSign != null)
	{
	var signature = signatureManager.GetSignatureForFile(new FileInfo(opts.BinaryToSign));
	Console.WriteLine($"Signature: {signature}", Color.Green);
	return;
	}

Is this feature broken somehow? If so, can you please describe how so someone can look into it?

Thanks!

[mgaberc-biosistemika]

Hi, thank you for your quick reply. Here is what I get in the console when trying to run the command I mentioned:

netsparkle-generate-appcast --generate-signature . --public-key-override YPaaa6K6eqSDIk0TSPMrw/K9mj0JXI9XHOum5XUevGU= --private-key-override nH1ukBGTVdEV9Ee0y4Z2zmingJFncR4r3PUaaa1kqAw
NetSparkleUpdaterAppCastGenerator 2.8.5+07673660e447cc5bdd737a36ddeb22e8bac0d556
Copyright c ndreisg 2019, Deadpikle 2020-2025

ERROR(S):
Options: 'public-key-override', 'private-key-override' are not compatible with: 'generate-signature'.
Option: 'generate-signature' is not compatible with: 'public-key-override', 'private-key-override'.

[Deadpikle]

Ah. Ok. I see. Yes that is an issue/bug that I did not see before. Sorry about that.

The fix should be quite straightforward and easy but it will take me a few days to have time to get to it. (Options.cs just needs a tweak, really.)

Thanks for the report.

[mgaberc-biosistemika]

I have created a PR for an easy fix if this helps you.
#647

[Deadpikle]

Fixed by #647