Add iroot and check argument for root #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I disabled the failing tests until Flint-2.9 comes out. I'll open a ticket so we |
Codecov Report
@@ Coverage Diff @@
## master #1118 +/- ##
=======================================
Coverage 86.10% 86.10%
=======================================
Files 66 66
Lines 23864 23873 +9
=======================================
+ Hits 20548 20557 +9
Misses 3316 3316
Continue to review full report at Codecov.
|
wbhart
changed the title
Contributor
Author
|
No longer requires flint-2.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Nemo part of Nemocas/AbstractAlgebra.jl#556
Also see #862
Note that this changes the semantics of root and so is technically breaking. In practice it still operates the same way in all possible prior use cases.