Skip to content

Remove _map for universal polys #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove _map for universal polys #2206

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9d393a
Remove `_map` for universal polys
SoongNoonien Nov 5, 2025
7506950
Upgrade if needed
SoongNoonien Nov 5, 2025
b193a53
Move variable check to `upgrade`
SoongNoonien Nov 6, 2025
2093761
Restore original kwarg name
SoongNoonien Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/generic/UnivPoly.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,8 +958,7 @@ end
_change_univ_poly_ring(R, Rx, cached::Bool) = universal_polynomial_ring(R, symbols(Rx); internal_ordering=internal_ordering(Rx), cached)[1]

function change_base_ring(R::Ring, p::UnivPoly{T}; cached::Bool=true, parent::UniversalPolyRing = _change_univ_poly_ring(R, parent(p), cached)) where {T <: RingElement}
base_ring(parent) != R && error("Base rings do not match.")
return _map(R, p, parent)
return UnivPoly(change_base_ring(R, data(p); parent = mpoly_ring(parent)), parent)
end

function change_coefficient_ring(R::Ring, p::UnivPoly{T}; cached::Bool=true, parent::UniversalPolyRing = _change_univ_poly_ring(R, parent(p), cached)) where {T <: RingElement}
Expand All @@ -973,17 +972,7 @@ end
################################################################################

function map_coefficients(f::T, p::UnivPoly; cached::Bool=true, parent::UniversalPolyRing = _change_univ_poly_ring(parent(f(zero(base_ring(p)))), parent(p), cached)) where T
return _map(f, p, parent)
end

function _map(g::T, p::UnivPoly, Rx) where T
cvzip = zip(coefficients(p), exponent_vectors(p))
M = MPolyBuildCtx(Rx)
for (c, v) in cvzip
push_term!(M, g(c), v)
end

return finish(M)
return UnivPoly(map_coefficients(f, data(p); parent = mpoly_ring(parent)), parent)
end

###############################################################################
Expand Down
Loading