Skip to content

Conversation

@fingolfin
Copy link
Member

For examples, this now works:

julia> is_domain_type(ZZ)
true

julia> is_domain_type(ZZ(2))
true

julia> is_domain_type(residue_ring(ZZ,6)[1])
false

For examples, this now works:

    julia> is_domain_type(ZZ)
    true

    julia> is_domain_type(ZZ(2))
    true

    julia> is_domain_type(residue_ring(ZZ,6)[1])
    false
@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.19%. Comparing base (9843ed5) to head (28b0cb3).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/Rings.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1942      +/-   ##
==========================================
- Coverage   88.21%   88.19%   -0.02%     
==========================================
  Files         119      119              
  Lines       30385    30391       +6     
==========================================
  Hits        26803    26803              
- Misses       3582     3588       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 4ae9859 into master Dec 20, 2024
27 of 29 checks passed
@thofma thofma deleted the mh/convenient-traits branch December 20, 2024 22:25
@aaruni96 aaruni96 added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: added PRs introducing changes that have since been mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants