-
Notifications
You must be signed in to change notification settings - Fork 0
Add in-review check #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
pubspec.yaml
Outdated
| package_info_plus: ^8.3.0 | ||
| http: ^1.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add 2 dependencies. Not sure if we can avoid it.
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
777fb9c to
47a04e8
Compare
| } else if (sourceName.compareTo('AppStore') == 0) { | ||
| // Installed ipa from App Store | ||
| return Source.IS_INSTALLED_FROM_APP_STORE; | ||
| } else if (appStoreVersion != null && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitsangwan01 what do you think about the condition here?
PR Type
Enhancement, Documentation
Description
Added
IS_IN_REVIEWsource detection for iOS/macOS.Integrated
package_info_plusandhttpdependencies for version checks.Updated documentation to reflect new
IS_IN_REVIEWfeature.Minor updates to macOS project configuration and example files.
Changes walkthrough 📝
GeneratedPluginRegistrant.swift
Register `package_info_plus` plugin for macOS.example/macos/Flutter/GeneratedPluginRegistrant.swift
package_info_plusplugin registration.AppDelegate.swift
Update macOS AppDelegate for secure state support.example/macos/Runner/AppDelegate.swift
@NSApplicationMainto@main.main.dart
Handle `IS_IN_REVIEW` source in main app.example/lib/main.dart
IS_IN_REVIEWcase handling in source detection.store_checker.dart
Add `IS_IN_REVIEW` detection logic and version checks.lib/store_checker.dart
IS_IN_REVIEWtoSourceenum.package_info_plusfor app version retrieval.fetchAppStoreVersionmethod for App Store version checks.IS_IN_REVIEWsource.README.md
Update README for `IS_IN_REVIEW` feature.README.md
IS_IN_REVIEWsource detection feature.IS_IN_REVIEW.Runner.xcscheme
Enable GPU validation mode in macOS scheme.example/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
pubspec.yaml
Add new dependencies for version checks.pubspec.yaml
package_info_plusandhttpdependencies.