Skip to content

Plamen5kov/revert #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Mar 8, 2018
Merged

Plamen5kov/revert #946

merged 44 commits into from
Mar 8, 2018

Conversation

@Plamen5kov
Copy link
Contributor

@Plamen5kov Plamen5kov commented Feb 12, 2018 •
edited by petekanev
Loading

This PR contains breaking changes for the upcoming 4.0 release

  • socket implementation
    Rewrite livesync implementation #929 (this is still not used by default .. but it can be enabled from RuntimeHelpers.java
  • folder structure Internal infrastructure changes
  • update android plugin for gradle to 3.0.1 from 2.3.3
  • deal with uglified js classes (fix class name resolution ...)
  • make tools debuggable (static binding generator, metadata generator, js parser)
  • make extended typescript->Java classes have unique names based on file name, line and column
  • refactor the app/build.gradle script to stop treating each android plugin as a product flavor.
  • when building an application, look for android and java libraries in App_Resources/Android and add them.
  • locate the project's App_Resources according to a property in the nsconfig.json configuration (if present).

Rebased on master

@Plamen5kov Plamen5kov requested a review from petekanev February 12, 2018 14:13
@Natalia-Hristova Natalia-Hristova added this to the 4.0.0 (TBD) milestone Feb 20, 2018
@ns-bot
Copy link

ns-bot commented Feb 26, 2018

💔

@petekanev
Copy link
Contributor

petekanev commented Feb 26, 2018

run ci

@ns-bot
Copy link

ns-bot commented Feb 26, 2018

💔

@miroslavaivanova
Copy link
Contributor

miroslavaivanova commented Feb 27, 2018

run ci

@ns-bot
Copy link

ns-bot commented Feb 27, 2018

💔

@miroslavaivanova
Copy link
Contributor

miroslavaivanova commented Feb 27, 2018

run ci

@ns-bot
Copy link

ns-bot commented Feb 27, 2018

💔

@petekanev
Copy link
Contributor

petekanev commented Feb 27, 2018

run ci

@ns-bot
Copy link

ns-bot commented Feb 27, 2018

💔

@miroslavaivanova
Copy link
Contributor

miroslavaivanova commented Feb 27, 2018

run ci

@ns-bot
Copy link

ns-bot commented Feb 27, 2018

💚

@miroslavaivanova
Copy link
Contributor

miroslavaivanova commented Feb 27, 2018

run ci

@ns-bot
Copy link

ns-bot commented Feb 27, 2018

💔

@miroslavaivanova
Copy link
Contributor

miroslavaivanova commented Feb 27, 2018

run ci

@ns-bot
Copy link

ns-bot commented Feb 27, 2018

💔

@ns-bot
Copy link

ns-bot commented Feb 28, 2018

💚

@NativeScript NativeScript deleted a comment from ns-bot Mar 2, 2018
@NativeScript NativeScript deleted a comment from ns-bot Mar 2, 2018
@NativeScript NativeScript deleted a comment from ns-bot Mar 2, 2018
@NativeScript NativeScript deleted a comment from ns-bot Mar 2, 2018
@NativeScript NativeScript deleted a comment from petekanev Mar 2, 2018
@NativeScript NativeScript deleted a comment from ns-bot Mar 2, 2018
@NativeScript NativeScript deleted a comment from ns-bot Mar 2, 2018
@NativeScript NativeScript deleted a comment from Natalia-Hristova Mar 2, 2018
@NativeScript NativeScript deleted a comment from ns-bot Mar 2, 2018
@NativeScript NativeScript deleted a comment from Natalia-Hristova Mar 2, 2018
@NativeScript NativeScript deleted a comment from ns-bot Mar 2, 2018
Plamen5kov and others added 23 commits March 7, 2018 11:21
@Plamen5kov
refactor(livesync): close socket when application process is killed
350dba1
@Plamen5kov
refactor(livesync): error handling shows file name that operation fai…
a409920 
…led for
@Plamen5kov
refactor(livesync): handle cases when livesync thread dies or is inte…
60f5fc1 
…rrupted
@Plamen5kov
feature: keep socket always open
a7197fa
@Plamen5kov
feature(livesnc): add dosync operation to avoid debouncing
1b98ff8
@Plamen5kov
refactor: keep new and old implementation of livesync
c8bfa36
@Plamen5kov
chore: fix merge conflicts
d4062b1
@Plamen5kov
chore: updated build script
d1b0d43
@Plamen5kov
refactor: added new livesync implementation in a separate file
fb160d0
@Plamen5kov
refactor: updated static binding generator tests to conform with newl…
653b5ab 
…y generated bindings protocol
@petekanev @Plamen5kov
fix(project-build-script): read app.gradle path from entry in nsconfi…
c4848b4 
…g.json
@petekanev @Plamen5kov
feat(project-build-script): respect aars and jars in app_resources/an…
f21a94e 
…droid/libs directory
@petekanev @Plamen5kov
add jarFiles from plugins as compile dependencies
fb4cd98
@petekanev @Plamen5kov
add jars and aar files from platforms/android/libs in plugins
bda5fe4
@petekanev @Plamen5kov
revert generated class name creation to include the base class name
b39015f
@petekanev @Plamen5kov
fix(runtime-binding-generator): address the changes in the class name…
187e8fd 
… format with shorter class names and support for typescript class extend location
@Plamen5kov
chore: fix build script
34926f7
@petekanev @Plamen5kov
chore: bump up version to 4.0.0
6499904
@Plamen5kov
chore: fix dist folder being deleted
9d6b86d
@petekanev @Plamen5kov
fix(project build script): update app_resources/ and app/ paths
c6ac0dc
@petekanev @Plamen5kov
chore(ci): update runtime build script to not delete /dist dir on run…
1254c11 
…tests
@petekanev @Plamen5kov
chore(runtime build script): fix rebase conflicts
7a312a4
@petekanev @Plamen5kov
fix(project-build-script): add plugin jar libraries as arguments for …
6af48b4 
…the SBG and MDG
@ns-bot
Copy link

ns-bot commented Mar 7, 2018

💚

@ns-bot
Copy link

ns-bot commented Mar 7, 2018

💚

@ns-bot
Copy link

ns-bot commented Mar 7, 2018

💚

@petekanev petekanev merged commit f88bfe0 into master Mar 8, 2018
@petekanev petekanev deleted the plamen5kov/revert branch March 8, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@petekanev petekanev petekanev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Plamen5kov Plamen5kov

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Plamen5kov @ns-bot @petekanev @miroslavaivanova @Natalia-Hristova