Rewrite livesync implementation #929
Merged
+237
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
Plamen5kov
force-pushed
the
plamen5kov/parse-buffers
branch
from
f41d06d to
7297e59
Compare
|
💔 |
|
💔 |
3 similar comments
|
💔 |
|
💔 |
|
💔 |
|
💔 |
Plamen5kov
force-pushed
the
plamen5kov/parse-buffers
branch
from
cbd2845 to
7998b18
Compare
|
💔 |
Plamen5kov
force-pushed
the
plamen5kov/parse-buffers
branch
from
079391b to
46a0087
Compare
|
💔 |
Plamen5kov
force-pushed
the
plamen5kov/parse-buffers
branch
from
46a0087 to
09bb963
Compare
|
💔 |
Plamen5kov
force-pushed
the
plamen5kov/revert
branch
from
e436947 to
5355eeb
Compare
Plamen5kov
force-pushed
the
plamen5kov/parse-buffers
branch
from
09bb963 to
155aa2b
Compare
|
💔 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
problem
livesync doesn't work the same way on all devices because of permission changes in upper API levels
solution
make livesync work with file content passing through unix sockets
expected behavior
files that are pushed to socket are created or deleted, depending on operation
Protocol:
create: (operation)(fileNameLength)(fileName)(fileContentLength)(fileContent)
Example of message sent through socket:
800007./a.txt0000000011fileContentdelete: (operation)(fileNameLength)(fileName)
Example of message sent through socket:
700003./aCreate example explained:
operation: 8 - create, 7 - delete (8)
fileNamelength: exactly 5 bytes (00007)
fileName: relative to app folder (./a.txt)
fileContentLength: exactly 10 bytes (0000000011)
fileContent: byte buffer (fileContent)