Skip to content

main branch: bugfix/sparsejac-46#48

Merged
c-randall merged 5 commits intomainfrom
bugfix/sparsejac-46
Mar 17, 2026
Merged

main branch: bugfix/sparsejac-46#48
c-randall merged 5 commits intomainfrom
bugfix/sparsejac-46

Conversation

@c-randall
Copy link
Copy Markdown
Collaborator

Description

Fixes bug where the user-defined jacfn option was being ignored when linsolver='sparse'. The issue has already been resolved in the v1.1.x maintenance branch, and a patched release v1.1.2 is already on PyPI and conda-forge. This PR ensures the main branch also has the fix. Per the maintenance policy, no other older versions will receive this patch. Only the latest release and any releases done within the last year are eligible for bug fixes.

Fixes #46

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that improves speed/readability/etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • Chore (any other clean up, maintenance, etc.)

Key checklist

  • No style issues: $ nox -s linter [-- format]
  • Code is free of misspellings: $ nox -s codespell [-- write]
  • All tests pass: $ nox -s tests
  • Badges are updated: $ nox -s badges

Further checks:

  • The documentation builds: $ nox -s docs.
  • Code is commented, particularly in hard-to-understand areas.
  • Tests are added that prove fix is effective or that feature works.

@c-randall c-randall marked this pull request as ready for review March 17, 2026 22:55
@c-randall c-randall merged commit 37476fa into main Mar 17, 2026
10 checks passed
@c-randall c-randall deleted the bugfix/sparsejac-46 branch March 17, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: User-supplied jacfn silently overwritten when sparsity is provided

1 participant