Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where the user-defined
jacfnoption was being ignored whenlinsolver='sparse'. The issue has already been resolved in thev1.1.xmaintenance branch, and a patched releasev1.1.2is already on PyPI and conda-forge. This PR ensures themainbranch also has the fix. Per the maintenance policy, no other older versions will receive this patch. Only the latest release and any releases done within the last year are eligible for bug fixes.Fixes #46
Type of change
Key checklist
$ nox -s linter [-- format]$ nox -s codespell [-- write]$ nox -s tests$ nox -s badgesFurther checks:
$ nox -s docs.