Skip to content

Conversation

@shorowit
Copy link
Contributor

@shorowit shorowit commented Dec 12, 2024

Pull Request Description

Bugfix for when a detailed schedule is used with higher resolution (e.g., 10-min data) than the simulation timestep (e.g., 60-min). Previously it would use the instantaneous schedule value that occurred at the beginning of each hour, now it will interpolate.

Example of results before:
image

And after:
image

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

….g., 10-min data) than the simulation timestep (e.g., 60-min).
@shorowit shorowit added the bug label Dec 12, 2024
@shorowit shorowit self-assigned this Dec 12, 2024
@shorowit shorowit marked this pull request as ready for review December 13, 2024 01:03
@shorowit
Copy link
Contributor Author

shorowit commented Dec 20, 2024

I compared the schedule csv full load hours to the simulation output full load hours for some random end uses, for the master branch and this branch.

  lighting_interior cooking_range dishwasher plug_loads_tv
sched data 2077 534 213 1505
outputs before 2063 581 216 1490
outputs after 2076 534 213 1506

The results in this branch are clearly better. I think that's enough validation that this is correct.

@shorowit shorowit merged commit 1ef1104 into master Dec 20, 2024
@shorowit shorowit deleted the schedule_file_interpolation branch December 20, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant