Skip to content

Handling unknown extensions for schedules#11375

Merged
mitchute merged 5 commits intoNatLabRockies:developfrom
bigladder:Fix-10675-Error-in-reading-an-external-schedule-file
Jan 14, 2026
Merged

Handling unknown extensions for schedules#11375
mitchute merged 5 commits intoNatLabRockies:developfrom
bigladder:Fix-10675-Error-in-reading-an-external-schedule-file

Conversation

@GaryMarksBigladder
Copy link
Contributor

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@GaryMarksBigladder GaryMarksBigladder marked this pull request as draft December 16, 2025 17:38
@michael-okeefe michael-okeefe added the Defect Includes code to repair a defect in EnergyPlus label Dec 16, 2025
eoh,
format("{} = {} has an unknown file extension and cannot be read by this program.", cAlphaFields(3), Alphas(3)));
ShowFatalError(state, "Program terminates due to previous condition.");
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly better than it was.

@mitchute mitchute marked this pull request as ready for review January 14, 2026 19:08
@mitchute mitchute self-requested a review January 14, 2026 19:08
Copy link
Collaborator

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Looks lovely.

@mitchute
Copy link
Collaborator

We'll let CI take one last pass and then merge.

@mitchute
Copy link
Collaborator

Okey-dokey. All good here. Merging.

@mitchute mitchute merged commit 21654d1 into NatLabRockies:develop Jan 14, 2026
11 checks passed
@mitchute mitchute deleted the Fix-10675-Error-in-reading-an-external-schedule-file branch January 14, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in Schedule:File when reading an external file

6 participants