Conversation
Contributor
Author
|
This is a followup to #11210 just fixing the eio output for tabular report style. Every file should show eio diffs like this. That's all. Assuming CI comes back like that, this should be ready to review and merge. |
|
|
|
|
mitchute
approved these changes
Oct 8, 2025
Collaborator
|
I resolved a merge conflict in the output rules file, but we don't need another CI cycle here. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Fixes Tabular Report style to eio output:
<Tabular Report>,Style,Unit Conversion. Previously this was only reported to the eio ifstate.dataOutRptTab->WriteTabularFileswas true inOutputReportTabular::GetInputTabularStyle. Due to the calling order inUpdateTabularReports, any file with onlyOutput:Table:SummaryReports(and not other types of table reports) would not write the style info to the eio output. Now it is always written, even for files withOutput Tabular=NoinOutputControl:Files.with this branch:
Pull Request Author
Reviewer