Skip to content

Fix eio output for table style#11260

Merged
mitchute merged 4 commits intodevelopfrom
TableFormatFollowup
Oct 9, 2025
Merged

Fix eio output for table style#11260
mitchute merged 4 commits intodevelopfrom
TableFormatFollowup

Conversation

@mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Oct 8, 2025

Pull request overview

Fixes Tabular Report style to eio output:

  • Add "Format Reals" option
  • Always report eio output for <Tabular Report>,Style,Unit Conversion. Previously this was only reported to the eio if state.dataOutRptTab->WriteTabularFiles was true in OutputReportTabular::GetInputTabularStyle. Due to the calling order in UpdateTabularReports, any file with only Output:Table:SummaryReports (and not other types of table reports) would not write the style info to the eio output. Now it is always written, even for files with Output Tabular=No in OutputControl:Files.
  • Fixes Unit Conversion reporting to eio when Column Separator input is anything other than "HTML". For example, testfile ShopWithBIPVT, output with develop:
! <Tabular Report>,Style,Unit Conversion
Tabular Report,Commaandhtml,commaandhtml

with this branch:

! <Tabular Report>,Style,Unit Conversion, Format Reals
Tabular Report,HTML,NONE,Yes

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze labels Oct 8, 2025
@mjwitte mjwitte added this to the EnergyPlus 25.2 IO Freeze milestone Oct 8, 2025
@mjwitte mjwitte marked this pull request as ready for review October 8, 2025 17:13
@mjwitte
Copy link
Contributor Author

mjwitte commented Oct 8, 2025

This is a followup to #11210 just fixing the eio output for tabular report style. Every file should show eio diffs like this.
image

That's all. Assuming CI comes back like that, this should be ready to review and merge.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit a246b9b

Regression Summary
  • EIO: 802
  • Table Big Diffs: 82

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

⚠️ Regressions detected on macos-14 for commit a246b9b

Regression Summary
  • EIO: 798
  • Table Big Diffs: 82

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 2232a56

Regression Summary
  • EIO: 802
  • Table Big Diffs: 82

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

⚠️ Regressions detected on macos-14 for commit 2232a56

Regression Summary
  • EIO: 798
  • Table Big Diffs: 82

@mitchute
Copy link
Collaborator

mitchute commented Oct 9, 2025

I resolved a merge conflict in the output rules file, but we don't need another CI cycle here. Merging.

@mitchute mitchute merged commit 7dde935 into develop Oct 9, 2025
8 checks passed
@mitchute mitchute deleted the TableFormatFollowup branch October 9, 2025 02:02
@mjwitte mjwitte added the RPD label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze RPD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants