Skip to content

Cache regressions followup#11192

Merged
Myoldmopar merged 8 commits intodevelopfrom
cache_regressions
Sep 5, 2025
Merged

Cache regressions followup#11192
Myoldmopar merged 8 commits intodevelopfrom
cache_regressions

Conversation

@jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Sep 5, 2025

Pull request overview

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

…4 (ghedesigner pulls scipy, which doesn't have binaries for arm64 WoA)
…ne, even if failed, and regardless of whether tests pass
…ve it

$ ls build_dir/testfiles/_ExternalInterface-functionalmockupunit-to-actuator/tmp-fmus/ShadingController.fmu_Model1/binaries

darwin64  linux32  linux64  win32  win64
@jmarrec jmarrec requested a review from Myoldmopar September 5, 2025 14:23
@jmarrec jmarrec self-assigned this Sep 5, 2025
@jmarrec jmarrec added Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) labels Sep 5, 2025
Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was a little quick there, merging again!

@Myoldmopar
Copy link
Member

Ok thanks for the typo fix, I'll be happy to merge in a bit.

@Myoldmopar Myoldmopar merged commit 4065fa6 into develop Sep 5, 2025
11 checks passed
@Myoldmopar Myoldmopar deleted the cache_regressions branch September 5, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) DoNotPublish Includes changes that shouldn't be reported in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants