Correction of Error in Xing Ground Temperature Model Get Input

[RKStrand]

Pull request overview

• Fixes GetGroundTempModelAndInit: Unable to read Xing #10981

For some reason, when the get input routine for the Xing model was executed, the variable objectName was being overwritten and turned into a blank field when GetObjectItem was called. The solution was to follow the method used by another ground temperature get routines which included moving the assignments for the base class to before the call to GetObjectItem. The unit test shows that the name and model type are preserved and no fatal error happens. Testing with the user example file no longer crashes but successfully completes.

Description of the purpose of this PR

This PR fixes the issue (user file now runs successfully) and includes a unit test.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

For some reason, when the get input routine for the Xing model was executed, the variable objectName was being overwritten and turned into a blank field when GetObjectItem was called.

The reason is almost certainly that both of them are trying to use the DataIPShortcuts object name variable to hold the current object name. This was a nice touch in Fortran, but completely unnecessary with C++, and we should try to just use a local string instead of the "global" object name variable whenever possible. Anyway, this is a fine fix. Merging. And thanks.