Fix #10378 - bump nlohmann/json to support most recent clang/apple-clang#11041
Fix #10378 - bump nlohmann/json to support most recent clang/apple-clang#11041Myoldmopar merged 10 commits intodevelopfrom
Conversation
|
I think I need to bump valijson too for MSVC... https://github.com/tristanpenman/valijson/releases/tag/v1.0.2
|
… use for matching date/times) and improve error messages
…acilities I must use a pointer to the RE2 member, because it's not movable (nor copyable, but don't care here)
Because we do lots of parsing the code sniffing out bad patterns and issues, and some of the parsing relies on a line-by-line analysis. And they don't keep track of multiline C style comments. So they could wreak havoc in those scripts. We can have discussions about it, but that's the real reason. If we want to allow them, we'll need to invest substantially to beef up our analysis scripts. |
|
Meh, I'm fine with it, easier to just shush it than change the scripts! |
Myoldmopar
left a comment
There was a problem hiding this comment.
Most excellent. Thanks @jmarrec !
Pull request overview
Description of the purpose of this PR
This bumps nlohmann/json from 3.7.2 to 3.12.0 (latest), so that it keeps on compiling with the most recent clang.
Pull Request Author
Reviewer