Add severe error when crankcase heater curve name is invalid#10963
Merged
Add severe error when crankcase heater curve name is invalid#10963
Conversation
mjwitte
approved these changes
Mar 3, 2025
Contributor
mjwitte
left a comment
There was a problem hiding this comment.
Tested with the defect file. Now there's a severe error:
** Severe ** Coil:Cooling:DX:CurveFit:Performance = HEAT PUMP ACDXCOIL 1 PERFORMANCE: Crankcase Heater Capacity Function of Temperature Curve Name not found = XYZ
** Fatal ** CoilCoolingDXCurveFitOperatingMode::instantiateFromInputSpecErrors found in getting Coil:Cooling:DX:CurveFit:Performance input. Preceding condition(s) causes termination.
CI is all green. Merging. Thanks @yujiex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
When the "Crankcase Heater Capacity Function of Temperature Curve Name" has an invalid name (the curve cannot be found), the simulation will crash. This PR adds a check on whether the curve is found and throws a severe error if not.
Description of the purpose of this PR
Pull Request Author
Reviewer