Skip to content

Add plant worker function to get current equipment capacity#10804

Merged
Myoldmopar merged 4 commits intodevelopfrom
New-plant-function-for-MaxLoad
Jan 10, 2025
Merged

Add plant worker function to get current equipment capacity#10804
Myoldmopar merged 4 commits intodevelopfrom
New-plant-function-for-MaxLoad

Conversation

@rraustad
Copy link
Collaborator

@rraustad rraustad commented Oct 25, 2024

Pull request overview

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Oct 25, 2024
@rraustad
Copy link
Collaborator Author

rraustad commented Oct 25, 2024 •
edited
Loading

With the new worker function the cooling tower can now meet the load.

image

rraustad
rraustad commented Oct 25, 2024
View reviewed changes
Copy link
Collaborator Author

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walk thru

src/EnergyPlus/CondenserLoopTowers.cc
}
}

Real64 CoolingTower::getDynamicMaxCapacity(EnergyPlusData &state)
Copy link
Collaborator Author

@rraustad rraustad Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tower calculations for current maximum capacity

src/EnergyPlus/Plant/Component.cc
if (this->compPtr == NULL) return this->MaxLoad;
Real64 possibleLoad = this->compPtr->getDynamicMaxCapacity(state);
return (possibleLoad == 0) ? this->MaxLoad : possibleLoad;
}
Copy link
Collaborator Author

@rraustad rraustad Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function will call the virtual function in PlantComponent.hh if a model does not have the override function (if that equipment's maximum capacity does not change this function is not needed) or will call the override function in the equipment model. If this function does not exist in an equipment model the virtual function will return 0 and MaxLoad will be used just as it is now. Otherwise the equipment model will return the current max capacity and that value will be used instead.

src/EnergyPlus/PlantComponent.hh
virtual Real64 getDynamicMaxCapacity([[maybe_unused]] EnergyPlusData &state)
{
return 0.0;
}
Copy link
Collaborator Author

@rraustad rraustad Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virtual function returns 0 if equipment model does not have an override function.

src/EnergyPlus/PlantCondLoopOperation.cc
void ManagePlantLoadDistribution(EnergyPlusData &state,
PlantLocation const &plantLoc, // PlantLoop data structure Location struct
Real64 &LoopDemand,
Real64 const LoopDemand,
Copy link
Collaborator Author

@rraustad rraustad Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CppCheck suggestion

src/EnergyPlus/PlantCondLoopOperation.cc
// load local variables from the data structures
CompMinLoad = this_component.MinLoad;
CompMaxLoad = this_component.MaxLoad;
CompMaxLoad = this_component.getDynamicMaxCapacity(state);
Copy link
Collaborator Author

@rraustad rraustad Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down at line 3763 is code that will cap MyLoad if the component design capacity cannot meet the load. Calling this function provides a more accurate full load capacity for use in plant manager calculations.

    // Check bounds on MyLoad
    if (std::abs(this_component.MyLoad) > CompMaxLoad) {
        this_component.MyLoad = sign(CompMaxLoad, this_component.MyLoad);
    }

@rraustad rraustad added this to the EnergyPlus 25.1 milestone Oct 25, 2024
@nrel-bot-2
Copy link

nrel-bot-2 commented Nov 22, 2024

@rraustad it has been 16 days since this pull request was last updated.

@nrel-bot-2c
Copy link

nrel-bot-2c commented Nov 29, 2024

@rraustad it has been 7 days since this pull request was last updated.

@Myoldmopar Myoldmopar self-assigned this Dec 4, 2024
@nrel-bot-2c
Copy link

nrel-bot-2c commented Dec 12, 2024

@Myoldmopar @rraustad it has been 7 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 21, 2024

@Myoldmopar @rraustad it has been 9 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Dec 28, 2024

@Myoldmopar @rraustad it has been 7 days since this pull request was last updated.

1 similar comment
@nrel-bot-2
Copy link

nrel-bot-2 commented Jan 4, 2025

@Myoldmopar @rraustad it has been 7 days since this pull request was last updated.

@Myoldmopar
Copy link
Member

Myoldmopar commented Jan 9, 2025

I think this will be ready to go now. I pulled in develop and it required one fluid line to be updated to the new fluid API. If it's all happy, I'll get this in.

@Myoldmopar
Copy link
Member

Myoldmopar commented Jan 10, 2025

Good to go, thanks @rraustad

@Myoldmopar Myoldmopar merged commit cba2624 into develop Jan 10, 2025
9 checks passed
@Myoldmopar Myoldmopar deleted the New-plant-function-for-MaxLoad branch January 10, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Myoldmopar Myoldmopar

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 25.1

Development

Successfully merging this pull request may close these issues.

Allow water plant to access equipment operating capacity for plant dispatch management

6 participants

@rraustad @nrel-bot-2 @nrel-bot-2c @Myoldmopar @nrel-bot @nrel-bot-2b