Skip to content

Fix chiller chilling when it is off #10793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myoldmopar merged 13 commits into from
Dec 4, 2024
Merged

Fix chiller chilling when it is off #10793

Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0e0005b
Warn if chiller chills when off
mjwitte Oct 17, 2024
e827c62
Warn if chiller chills when off
mjwitte Oct 17, 2024
394a2c7
Fix chiller off when condenser flow is zero
mjwitte Oct 17, 2024
172283a
Revert Warn if chiller chills when off
mjwitte Oct 18, 2024
c894587
Fix chiller off when condenser flow is zero for all other chillers
mjwitte Oct 29, 2024
85be6e1
Merge remote-tracking branch 'remotes/origin/develop' into chillerEIR…
mjwitte Nov 13, 2024
ba3f01d
Merge remote-tracking branch 'remotes/origin/develop' into chillerEIR…
mjwitte Nov 15, 2024
a87f0ad
Extend EIR chiller unit test
mjwitte Nov 15, 2024
dfcd0c1
Set evapmassflow to zero
mjwitte Nov 15, 2024
4f9f8b1
Merge remote-tracking branch 'remotes/origin/develop' into chillerEIR…
mjwitte Nov 18, 2024
7d3063a
Set evapmassflow to zero
mjwitte Nov 18, 2024
1ecc79e
undo VS formatting
mjwitte Nov 18, 2024
bbcd4ce
Merge remote-tracking branch 'remotes/origin/develop' into chillerEIR…
mjwitte Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/EnergyPlus/ChillerElectricEIR.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1962,6 +1962,8 @@ void ElectricEIRChillerSpecs::calculate(EnergyPlusData &state, Real64 &MyLoad, b
state, this->CWPlantLoc, this->CondMassFlowIndex, this->CDPlantLoc, DataPlant::CriteriaType::MassFlowRate, this->CondMassFlowRate);

if (this->CondMassFlowRate < DataBranchAirLoopPlant::MassFlowTolerance) {
// Shut chiller off if there is no condenser water flow
MyLoad = 0.0;
Copy link
Collaborator

@rraustad rraustad Oct 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look like it boils down to this. I looked at PullCompInterconnectTrigger to see what that was trying to accomplish. This code looks like it can be deleted. I'm not asking for that to happen here but it's extra clock cycles. Removed in #10794,

    // Check to make sure we didn't reuse the index in multiple components
    if (CurCriteria.CallingCompLoopNum != plantLoc.loopNum || CurCriteria.CallingCompLoopSideNum != plantLoc.loopSideNum ||
        CurCriteria.CallingCompBranchNum != plantLoc.branchNum || CurCriteria.CallingCompCompNum != plantLoc.compNum) {
        // Diagnostic fatal: component does not properly utilize unique indexing
    }

if (this->EvapMassFlowRate < DataBranchAirLoopPlant::MassFlowTolerance) {
// Use PlantUtilities::SetComponentFlowRate to decide actual flow
PlantUtilities::SetComponentFlowRate(
Expand Down