-
Notifications
You must be signed in to change notification settings - Fork 461
Extended HI followup: fix speed issue #10733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
28bdb41
change rootsolver to BisectionThenRegulaFalsi to speed up
b9fe27e
Merge remote-tracking branch 'origin/develop' into extendedHIspeedFix
6e8fcc8
Revert "Revert "Adopt the Extended Heat Index calculation in zone res…
b23f9ad
change root solver to BisectionThenRegulaFalsi for speed
bd97716
save Zs(Rs) value in a variable
5e96092
find eqvar name and value together
b96c3a5
update unit test find_eqvar_name and value
6600069
save Ra_bar calculation result
58a77d9
restrict domain of extended HI application
yujiex 16faa31
Revert "restrict domain of extended HI application"
yujiex 4f4809f
try using a shorter termination for bisection solver
yujiex aa7352d
Merge remote-tracking branch 'origin/extendedHIspeedFix' into extende…
ec8f0ba
Try using RegulaFalsiThenBisection
9e32af5
Revert "save Ra_bar calculation result"
f488176
Revert "Try using RegulaFalsiThenBisection"
b813d6e
Revert "Revert "restrict domain of extended HI application""
23c3005
fix application domain equation
ec88e02
Add global control of heat index method choice
88aa6fb
fix unit test
87081c2
Merge remote-tracking branch 'origin/develop' into extendedHIspeedFix
c445919
add back doc about Rothfusz-Steadman method, change version num
ac88314
change function args to const arg
e12b3a2
change local var to const
ea1eb0e
rename HVACSystemRootSolver to HVACSystemRootSolverMethod
56cf873
use existing F to C conversion function
663e087
Merge remote-tracking branch 'origin/develop' into extendedHIspeedFix
f22d31a
license year update
114c4f1
File rename ExtendedHI to ExtendedHeatIndex
5c7d6fa
Change idd obj name to OutputControl:ResilienceSummaries w doc change
70091eb
use getEnumValue for HVACSystemRootSolverMethod
d7d4539
remove global variables
02510f2
clang-format
ec56408
license year in .hh
53491a1
directly use the enum class EqvarName instead of casting
962608f
use ShowWarningInvalidKey for warning message
7e51320
more removal of global vars
6241263
clang-format, change enum EqvarName to start from 0
756096b
change root finding tolerance, clang-format
7cc4fd6
doc input section latex label fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When viewing the changes on github, there is a warning about this line:
Labelinputs-8-020' multiply defined.`There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me check on why this happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, my label for the inputs section in my latex documentation collides with a existing one. I just changed the label.