-
Notifications
You must be signed in to change notification settings - Fork 461
Add performance support for ASHRAE205 Coils (RS0004) #10307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
2ae86bf
Add NFP draft document.
nealkruis 1becf54
Flesh out NFP implementation.
tanaya-mankad 79160f3
Fix typo.
tanaya-mankad 63406e5
Modify idf inputs for 205 coils.
tanaya-mankad 16e5855
Add most recent libtk205 files.
tanaya-mankad 9d39010
Merge branch 'fix-btwxt-error-handling' into ashrae-205-coils
tanaya-mankad 192a40a
Merge from NREL develop; btwxt-error-handling.
tanaya-mankad 8a06349
Merge branch 'ashrae-205-coils' of https://github.com/bigladder/energ…
tanaya-mankad dc35ed4
Begin adding performance base class
tanaya-mankad f3e9e57
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad 17724fc
Move code to performance base class as necessary.
tanaya-mankad 07a8dd8
Commit json submodule files; E+ custom target name for nlohmann-json …
tanaya-mankad 4493436
Replace previously ignored CMakeLists.
tanaya-mankad 2724741
Commit json build file for Windows.
tanaya-mankad 7745c10
Begin using base class functions in tests.
tanaya-mankad 5e9aa32
Make tests explicitly use CurveFitPerformance for CoilDX tests.
tanaya-mankad ca1692d
Add basic calculations to 205 coil class.
tanaya-mankad f0a7c63
Add basic simulate function (as CurveFit, but alternate modes removed).
tanaya-mankad ff81c53
Use fmt format for error strings.
tanaya-mankad 0611def
Corrected usage of format().
tanaya-mankad 508937e
Merge from NREL develop.
tanaya-mankad d89a8bb
Fix CI-requested problems.
tanaya-mankad 972c919
Fix typo bug.
tanaya-mankad b644c90
Fix override typos.
tanaya-mankad 4736c13
Add crankcase heater code from develop.
tanaya-mankad 1873d0e
Create explicit performance object for tests.
tanaya-mankad eef8f80
Fix clang-tidy errors.
tanaya-mankad 8ecd059
Comment unused parameter.
tanaya-mankad 7aa8fa9
Begin assembling simple model for 205 coils.
tanaya-mankad 1a574b3
Merge from upstream branches.
tanaya-mankad 9d0c89d
Apply formatting.
tanaya-mankad 17fad52
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad 1356b5b
Merge branch 'merge-coil-load-ratios' into ashrae-205-coils
tanaya-mankad b0ebe85
Fix logging for libtk205.
tanaya-mankad 6406e6c
Merge branch 'merge-coil-load-ratios' of https://github.com/bigladder…
tanaya-mankad e18921a
Add example model with 205 cooling coil.
tanaya-mankad bb6f090
Update output node calculations.
tanaya-mankad 1c2b496
Add sizing stub.
tanaya-mankad 785efca
Add rated gross cooling capacity to 205 performance.
tanaya-mankad 575d906
Fix formatting.
tanaya-mankad 5861c48
Change tabs to spaces.
tanaya-mankad fdfa1d4
Fix performance pointer for CurveFit tests.
tanaya-mankad 5069521
Replace default values in performance parameter access functions with…
tanaya-mankad b4f3e0f
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad 6ac136a
Fix custom-check errors.
tanaya-mankad aa9f04e
Add state parameter.
tanaya-mankad 059d111
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad b1fed16
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad 66ef4f3
Normalize function names; clean up code.
tanaya-mankad 0c82665
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad 7e2a014
Add Latex documentation for 205 coil object.
tanaya-mankad 44cc97c
Code integrity fix; documentation image update.
tanaya-mankad 6c4c12d
Clean up scoping.
tanaya-mankad 39faad2
Fix formatting.
tanaya-mankad 1182a94
Move function using state to impl file.
tanaya-mankad 2b151a0
Merge branch 'merge-coil-load-ratios' into ashrae-205-coils
tanaya-mankad f0c80b3
Fix power use calculation.
tanaya-mankad 7023b42
Separate speeds by index vs compressor speed number.
tanaya-mankad 3354903
Fix volumetric vs mass flows. Fix modulating/switching simulation.
tanaya-mankad 43da137
Clang format.
tanaya-mankad 7e5aa83
Merge branch 'merge-coil-load-ratios' into ashrae-205-coils
tanaya-mankad aea193b
Merge branch 'merge-coil-load-ratios' into ashrae-205-coils
tanaya-mankad 39fe02c
Merge from develop.
tanaya-mankad 92ced14
Fix license year.
tanaya-mankad 694c610
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad a6b74c2
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad 03dc8cd
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad 1c88e8f
Merge upstream develop, resolve conflicts
Myoldmopar 2e184e7
Replace double with Real64.
tanaya-mankad a277170
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into ash…
tanaya-mankad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| # ASHRAE 205 Coils | ||
|
|
||
| **Tanaya Mankad, Neal Kruis; Big Ladder Software** | ||
|
|
||
| ## Overview | ||
|
|
||
| ASHRAE Standard 205 defines common data models and serialization formats for facility equipment performance data needed for engineering applications such as energy simulation. The formats allow automated exchange among data sources (manufacturers), simulation models, and other engineering applications. The formats and procedures specified in the standard are developed by SPC (Standard Project Committee) 205 under ASHRAE and ANSI consensus processes. SSPC-205 membership includes equipment manufacturers, application software developers, and engineering practitioners. | ||
|
|
||
| The initial edition of the standard was published near the beginning of 2023; an overview can be found at http://data.ashrae.org/standard205/. | ||
|
|
||
| 205 chillers (RS0001) were added to EnergyPlus in 22.2. In this NFP, we propose to add support for RS0004 (Air-to-Air Direct Expansion Refrigerant System). The current scope of this RS is limited to cooling DX coils, but future adenda will accommodate heating DX coils as well. | ||
|
|
||
| ## Implementation | ||
|
|
||
| ASHRAE 205 coil performance will be indicated through a new object, `Coil:DX:ASHRAE205:Performance`, which will be referenceable from `Coil:Cooling:DX` object (and the future `Coil:Heating:DX` object). The current `Coil:[Cooling]:DX:CurveFit:Performance` object and the new performance object will both derive from a new base class that encapsulates common functionality and isolates the performance calculation. (Making this structural change will ease the transition to a future Coil:Heating:DX:Curvefit:Performance object, should a non-205 performance imlementation ever be desired.) | ||
|
|
||
| Standard 205 representations are stored in either human-readable JSON or serialized CBOR (Concise Binary Object Representation) format. libtk205 (Toolkit 205) library will populate the internal EnergyPlus class data. | ||
|
|
||
| ### Calculations | ||
|
|
||
| One of the advantages of ASHRAE Standard 205 is that available equipment operating conditions must be provided as raw performance maps in a representation. These performance maps are straightforward to arrange in a tabular format, which the libtk205 library passes to the same multi-dimensional interpolation engine ([btwxt](https://github.com/bigladder/btwxt)) which is already used in EnergyPlus to calculate performance at different operating conditions. Rather than being extracted from a regression curve, which can produce physically unrealistic results near their boundaries and can fail to capture internal inflections, equipment performance is interpolated within the closest available data to the operating point. The performance calculation will be embedded in the `simulate()` function of the DX coil class. | ||
|
|
||
| ## Testing | ||
|
|
||
| In order to test the new `Coil:DX:ASHRAE205:Performance` object, we will create a new model based on an existing one with `Coil:Cooling:DX:Curvefit:Performance`. A new ASHRAE 205 representation file will be created using performance characteristics from the known model, using its performance curves to back-calculate the tabular parameter and lookup information required by the new representation. We will ensure results between the two files are similar, within reason. | ||
|
|
||
| ## IDD Changes and Transition | ||
|
|
||
| We will add a new object `Coil:DX:ASHRAE205:Performance`. | ||
|
|
||
| ``` | ||
| Coil:DX:ASHRAE205:Performance, | ||
| \memo DX coil performance specification referencing an ASHRAE Standard 205 compliant representation | ||
| \memo for air-to-air direct expansion refrigerant system (Representation Specification RS0004). As | ||
| \memo RS0004 files are intended to support both heating and cooling performance, this object may | ||
| \memo referenced by the Coil:Cooling:DX and the corresponding Coil:Heating:DX object (planned for | ||
| \memo future addition). | ||
| \min-fields 2 | ||
| A1, \field Name | ||
| \required-field | ||
| \type alpha | ||
| \reference DXCoolingPerformanceNames | ||
| !\reference DXHeatingPerformanceNames | ||
| A2, \field Representation File Name | ||
| \note The name of the ASHRAE 205 RS0004 (air-to-air direct expansion refrigerant system) representation file | ||
| \type alpha | ||
| \retaincase | ||
| \required-field | ||
| A3, \field Performance Interpolation Method | ||
| \type choice | ||
| \key Linear | ||
| \key Cubic | ||
| \default Linear | ||
| N1, \field Rated Total Cooling Capacity | ||
| \note Not yet implemented / reserved for future use. Full load cooling capacity at AHRI 210/240 "A" test conditions. | ||
| \note Used to scale representation data. | ||
| \type real | ||
| \units W | ||
| \minimum> 0.0 | ||
| \autosizable | ||
| \default autosize | ||
| N2; \field Rated Steady-State Heating Capacity | ||
| \note Not yet implemented / reserved for future use. Full load heating capacity at AHRI 210/240 "H1" test conditions. | ||
| \note Used to scale representation data. | ||
| \type real | ||
| \units W | ||
| \minimum> 0.0 | ||
| \autosizable | ||
| \default autosize | ||
| ``` | ||
|
|
||
| ## Documentation | ||
|
|
||
| Much of the content above will be modified to describe the feature in "Input Output Reference", and details of the aggregation calculations in "Engineering Reference". |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, in LaTeX, we prefer ``backticks then apostrophes'' and let TeX render them as it sees fit. Don't need to hold this up for it.